Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-10-04 Thread Martin Wilck
On Fri, 2017-09-29 at 16:59 -0600, Keith Busch wrote: > On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote: > > In the NVME subsystem, we're seeing a race condition with udev > > where > > device_add_disk() is called (which triggers an "add" uevent), and a > > sysfs attribute group is add

Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-10-04 Thread Martin Wilck
On Sun, 2017-10-01 at 10:00 +0200, Christoph Hellwig wrote: > While this looks okay-ish to me I really don't want people confused > with three variants of add_disk, we really need to consolidate > our helpers there a bit.. > Can you give me a hint what you'd like to see? Martin -- Dr. Martin W

Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-10-02 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-10-01 Thread Christoph Hellwig
While this looks okay-ish to me I really don't want people confused with three variants of add_disk, we really need to consolidate our helpers there a bit..

Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-09-29 Thread Keith Busch
On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote: > In the NVME subsystem, we're seeing a race condition with udev where > device_add_disk() is called (which triggers an "add" uevent), and a > sysfs attribute group is added to the disk device afterwards. > If udev rules access these att

RE: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-09-29 Thread Schremmer, Steven
> From: Linux-nvme [mailto:linux-nvme-boun...@lists.infradead.org] On Behalf Of > Martin Wilck > Sent: Thursday, September 28, 2017 2:37 PM > To: Jens Axboe ; Christoph Hellwig ; Johannes > Thumshirn > Cc: linux-bl...@vger.kernel.org; Martin Wilck ; > linux-kernel@vger.kernel.org; linux-n...@li