Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-23 Thread Shi, Yang
Hi folks, Any more comments on this patch (store immediate only)? I need more time to add XADD (I'm supposed everyone agrees it is equivalent to atomic_add). However, this one is irrelevant to XADD, so we may be able to apply it first? Thanks, Yang On 11/12/2015 7:45 PM, Z Lim wrote: On T

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-12 Thread Z Lim
On Thu, Nov 12, 2015 at 11:33 AM, Shi, Yang wrote: > On 11/11/2015 4:39 AM, Will Deacon wrote: >> >> Wait a second, we're both talking rubbish here :) The STR (immediate) >> form is referring to the addressing mode, whereas this patch wants to >> store an immediate value to memory, which does need

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-12 Thread Shi, Yang
On 11/11/2015 4:39 AM, Will Deacon wrote: On Wed, Nov 11, 2015 at 12:12:56PM +, Will Deacon wrote: On Tue, Nov 10, 2015 at 06:45:39PM -0800, Z Lim wrote: On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote: aarch64 doesn't have native store immediate instruction, such operation Actually, aa

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-11 Thread Will Deacon
On Wed, Nov 11, 2015 at 12:12:56PM +, Will Deacon wrote: > On Tue, Nov 10, 2015 at 06:45:39PM -0800, Z Lim wrote: > > On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote: > > > aarch64 doesn't have native store immediate instruction, such operation > > > > Actually, aarch64 does have "STR (immedi

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-11 Thread Will Deacon
On Tue, Nov 10, 2015 at 06:45:39PM -0800, Z Lim wrote: > On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote: > > aarch64 doesn't have native store immediate instruction, such operation > > Actually, aarch64 does have "STR (immediate)". For arm64 JIT, we can > consider using it as an optimization. Y

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-10 Thread Z Lim
On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote: > aarch64 doesn't have native store immediate instruction, such operation Actually, aarch64 does have "STR (immediate)". For arm64 JIT, we can consider using it as an optimization. You may also want to consider adding a note about the correspondin