Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

On Tuesday 12 February 2008 04:41:42 Linus Torvalds wrote: > > On Mon, 11 Feb 2008, Carlos Corbacho wrote: > > > > WMI drivers, like their ACPI counterparts, should also check if ACPI is > > disabled or not, and bail out if so, otherwise we cause a crash. > > Shouldn't "wmi_has_guid()" just retu

Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

* Linus Torvalds <[EMAIL PROTECTED]> wrote: > @@ -673,11 +673,11 @@ static int __init acpi_wmi_init(void) > { > acpi_status result; > > + INIT_LIST_HEAD(&wmi_blocks.list); > + > if (acpi_disabled) > return -ENODEV; > > - INIT_LIST_HEAD(&wmi_blocks.list); > -

Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

On Mon, 11 Feb 2008, Carlos Corbacho wrote: > > WMI drivers, like their ACPI counterparts, should also check if ACPI is > disabled or not, and bail out if so, otherwise we cause a crash. Shouldn't "wmi_has_guid()" just return false if ACPI isn't enabled, and the drivers should just then always