Re: [PATCH 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

On Friday, December 19, 2014 11:51:33 AM Jonathan Richardson wrote: > Thanks Joe. I'll send out a new patch set with your suggestions/fixes > shortly. You can also drop the remove() code since we clear drvdata automatically and input device is managed so does not need to be unregistered explicitl

Re: [PATCH 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

Thanks Joe. I'll send out a new patch set with your suggestions/fixes shortly. On 14-12-17 06:14 PM, Joe Perches wrote: > On Wed, 2014-12-17 at 17:59 -0800, Jonathan Richardson wrote: >> Add initial version of the Broadcom touchscreen driver. > > trivia: > >> diff --git a/drivers/input/touchscre

Re: [PATCH 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

On Wed, 2014-12-17 at 17:59 -0800, Jonathan Richardson wrote: > Add initial version of the Broadcom touchscreen driver. trivia: > diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c > b/drivers/input/touchscreen/bcm_iproc_tsc.c > +/* Bit values for REGCTL2 */ > +#define TS_CONTROLLER_EN_BIT