Re: [PATCH 1/2] (repost) New System call, unshare (fwd)

2005-09-08 Thread Janak Desai
Nick Piggin wrote: Janak Desai wrote: -tsk->min_flt = tsk->maj_flt = 0; -tsk->nvcsw = tsk->nivcsw = 0; +/* + * If the process memory is being duplicated as part of the + * unshare system call, we are working with the current process + * and not a newly allocated task s

Re: [PATCH 1/2] (repost) New System call, unshare (fwd)

2005-09-08 Thread Janak Desai
Thanks again for your review. I understand the problems that you highlighted. I will rework the code and this time create test programs that test these aspects of unsharing that I had missed. Basically, the four areas that I have to fix are - Investigate impact on aio and futex - Handle possib

Re: [PATCH 1/2] (repost) New System call, unshare (fwd)

2005-09-07 Thread Janak Desai
Thanks Chris and Nick for your feedback. I am investigating the issues that you raised. Hopefully I will address them by COB tomorrow. -Janak Chris Wright wrote: * Janak Desai ([EMAIL PROTECTED]) wrote: diff -Naurp linux-2.6.13-mm1/kernel/fork.c linux-2.6.13-mm1+unshare-patch1/kernel/fork.

Re: [PATCH 1/2] (repost) New System call, unshare (fwd)

2005-09-07 Thread Nick Piggin
Janak Desai wrote: - tsk->min_flt = tsk->maj_flt = 0; - tsk->nvcsw = tsk->nivcsw = 0; + /* +* If the process memory is being duplicated as part of the +* unshare system call, we are working with the current process +* and not a newly allocated task stru

Re: [PATCH 1/2] (repost) New System call, unshare (fwd)

2005-09-07 Thread Chris Wright
* Janak Desai ([EMAIL PROTECTED]) wrote: > diff -Naurp linux-2.6.13-mm1/kernel/fork.c > linux-2.6.13-mm1+unshare-patch1/kernel/fork.c > --- linux-2.6.13-mm1/kernel/fork.c2005-09-07 13:25:01.0 + > +++ linux-2.6.13-mm1+unshare-patch1/kernel/fork.c 2005-09-07 > 13:40:11.0