Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows

2025-04-22 Thread Halil Pasic
On Wed, 16 Apr 2025 15:49:40 +0200 Amit Shah wrote: > On Sat, 2025-03-22 at 01:29 +0100, Halil Pasic wrote: > > As per virtio spec the fields cols and rows are specified as little > > endian. Although there is no legacy interface requirement that would > > state that cols and rows need to be hand

Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows

2025-04-16 Thread Amit Shah
On Sat, 2025-03-22 at 01:29 +0100, Halil Pasic wrote: > As per virtio spec the fields cols and rows are specified as little > endian. Although there is no legacy interface requirement that would > state that cols and rows need to be handled as native endian when > legacy > interface is used, unlike

Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows

2025-04-04 Thread Michael S. Tsirkin
On Wed, Apr 02, 2025 at 05:26:59PM +0200, Halil Pasic wrote: > On Sat, 22 Mar 2025 01:29:54 +0100 > Halil Pasic wrote: > > > As per virtio spec the fields cols and rows are specified as little > > endian. > [..] > > @Amit: Any feedback? > > > > > Fixes: 8345adbf96fc1 ("virtio: console: Accept

Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows

2025-04-02 Thread Halil Pasic
On Sat, 22 Mar 2025 01:29:54 +0100 Halil Pasic wrote: > As per virtio spec the fields cols and rows are specified as little > endian. [..] @Amit: Any feedback? > > Fixes: 8345adbf96fc1 ("virtio: console: Accept console size along with resize > control message") > Signed-off-by: Halil Pasic

Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows

2025-03-24 Thread Maximilian Immanuel Brandtner
On Sat, 2025-03-22 at 01:29 +0100, Halil Pasic wrote: > As per virtio spec the fields cols and rows are specified as little > endian. Although there is no legacy interface requirement that would > state that cols and rows need to be handled as native endian when > legacy > interface is used, unlike