Re: [PATCH 1/1] rtc: gemini: add return value validation

2017-05-04 Thread Alexandre Belloni
On 23/04/2017 at 20:48:07 +0800, Pan Bian wrote: > From: Pan Bian > > Function devm_ioremap() will return a NULL pointer if it fails to remap > IO address, and its return value should be validated before it is used. > However, in function gemini_rtc_probe(), its return value is not > checked. Thi

Re: [PATCH 1/1] rtc: gemini: add return value validation

2017-04-26 Thread Hans Ulli Kroll
HI Pan, On Sun, 23 Apr 2017, Pan Bian wrote: > From: Pan Bian > > Function devm_ioremap() will return a NULL pointer if it fails to remap > IO address, and its return value should be validated before it is used. > However, in function gemini_rtc_probe(), its return value is not > checked. This