Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-11-07 Thread Oded Gabbay
On 11/06/2014 03:33 PM, Joerg Roedel wrote: > On Sat, Oct 18, 2014 at 12:43:27AM +0300, Oded Gabbay wrote: >> 3. Later, amdkfd's mmu notifier callback (kfd_process_notifier_release()) >> gets >>called and releases more things that are related to the process. >>In that function, amd_iommu

Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-11-06 Thread Joerg Roedel
On Thu, Nov 06, 2014 at 03:48:51PM +0200, Oded Gabbay wrote: > What do you mean ? I don't see I change anything in the API. All the > changes are internal to amd_iommu_unbind_pasid(). I don't think > *anyone* calling to amd_iommu_unbind_pasid() will care or will > notice the slight change in timing

Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-11-06 Thread Oded Gabbay
On 11/06/2014 03:33 PM, Joerg Roedel wrote: On Sat, Oct 18, 2014 at 12:43:27AM +0300, Oded Gabbay wrote: 3. Later, amdkfd's mmu notifier callback (kfd_process_notifier_release()) gets called and releases more things that are related to the process. In that function, amd_iommu_unbind_pa

Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-11-06 Thread Joerg Roedel
On Sat, Oct 18, 2014 at 12:43:27AM +0300, Oded Gabbay wrote: > 3. Later, amdkfd's mmu notifier callback (kfd_process_notifier_release()) gets >called and releases more things that are related to the process. >In that function, amd_iommu_unbind_pasid() is explicitly called. Can't you just r

Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-11-03 Thread Oded Gabbay
Hi Joerg, Could you please review this patch ? Thanks, Oded On 10/25/2014 10:16 PM, Oded Gabbay wrote: Hi, Could anyone please review this patch ? Thanks, Oded On 18/10/14 00:43, Oded Gabbay wrote: This patch makes use of the new delayed mmu release notifier feature in mm c

Re: [PATCH 1/1] iommu/amd: Use delayed mmu release notifier

2014-10-25 Thread Oded Gabbay
Hi, Could anyone please review this patch ? Thanks, Oded On 18/10/14 00:43, Oded Gabbay wrote: > This patch makes use of the new delayed mmu release notifier feature in > mm code. This is necessary because on the one hand amd_iommu_unbind_pasid > must be called explicitly during the tear-