Re: Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Al Viro
On Fri, Aug 17, 2018 at 08:51:42AM +0530, Srikanth Korangala Hari wrote: > > Thanks for the patch! Do you have a reproducer or is this theoretical? > > This will affect if it should go to stable or not. > > Dear Luis, this is theoretical as I observed in most of the call's to api - > "proc_mkdir"

RE: Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Srikanth Korangala Hari
> It is fine to crash because /proc is not modular. Dear Alexey, this was theoretical solution. If you feel this should crash instead if the call fail's then ignore the patch. Regards, Srikanth  

RE: Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Srikanth Korangala Hari
> Thanks for the patch! Do you have a reproducer or is this theoretical? > This will affect if it should go to stable or not. Dear Luis, this is theoretical as I observed in most of the call's to api - "proc_mkdir" the NULL check is being done. Hence I thought of adding one here. Regards, Srikan

Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Luis Chamberlain
On Thu, Aug 16, 2018 at 03:04:13PM +0530, Srikanth K H wrote: > If the make directory for "sys" interface fail's then its > dereferenced without even checking for its validity which > will lead to crash, hence added preventive code to check > for NULL and accordingly dereference. > > Signed-off-by

Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Alexey Dobriyan
On Thu, Aug 16, 2018 at 03:04:13PM +0530, Srikanth K H wrote: > If the make directory for "sys" interface fail's then its > dereferenced without even checking for its validity which > will lead to crash, hence added preventive code to check > for NULL and accordingly dereference. > --- a/fs/proc/p