Re: [PATCH 1/1] PCI: fix on-stack pci_device_id's

2012-09-10 Thread Bjorn Helgaas
On Mon, Sep 10, 2012 at 4:55 PM, Fengguang Wu wrote: > On Mon, Sep 10, 2012 at 02:44:32PM -0600, Bjorn Helgaas wrote: >> On Mon, Sep 10, 2012 at 1:36 PM, Jiri Slaby wrote: >> > Commit "PCI: Use pci_device_id on stack for pci_get_subsys/class() to >> > avoid kmalloc" changed heap allocations to on

Re: [PATCH 1/1] PCI: fix on-stack pci_device_id's

2012-09-10 Thread Fengguang Wu
On Mon, Sep 10, 2012 at 02:44:32PM -0600, Bjorn Helgaas wrote: > On Mon, Sep 10, 2012 at 1:36 PM, Jiri Slaby wrote: > > Commit "PCI: Use pci_device_id on stack for pci_get_subsys/class() to > > avoid kmalloc" changed heap allocations to on-stack variables, but it > > did not add initialization of

Re: [PATCH 1/1] PCI: fix on-stack pci_device_id's

2012-09-10 Thread Bjorn Helgaas
On Mon, Sep 10, 2012 at 1:36 PM, Jiri Slaby wrote: > Commit "PCI: Use pci_device_id on stack for pci_get_subsys/class() to > avoid kmalloc" changed heap allocations to on-stack variables, but it > did not add initialization of other than set members. This causes > random failures during bootup whe