Re: [PATCH 09/39] mtd: nand: denali: fix erased page check code

2016-12-01 Thread Boris Brezillon
On Fri, 2 Dec 2016 13:33:58 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2016-11-28 0:21 GMT+09:00 Boris Brezillon > : > > On Sun, 27 Nov 2016 03:05:55 +0900 > > Masahiro Yamada wrote: > > > >> Currently, is_erased() is called against "buf" twice, so the second > >> call is meaningless.

Re: [PATCH 09/39] mtd: nand: denali: fix erased page check code

2016-12-01 Thread Masahiro Yamada
Hi Boris, 2016-11-28 0:21 GMT+09:00 Boris Brezillon : > On Sun, 27 Nov 2016 03:05:55 +0900 > Masahiro Yamada wrote: > >> Currently, is_erased() is called against "buf" twice, so the second >> call is meaningless. The second one should be checked against >> chip->oob_poi. >> > > IMO, patch 9 to

Re: [PATCH 09/39] mtd: nand: denali: fix erased page check code

2016-11-27 Thread Boris Brezillon
On Sun, 27 Nov 2016 03:05:55 +0900 Masahiro Yamada wrote: > Currently, is_erased() is called against "buf" twice, so the second > call is meaningless. The second one should be checked against > chip->oob_poi. > IMO, patch 9 to 12 should be squashed in a single patch. All you're doing in these