Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-26 Thread Eric W. Biederman
"J. Bruce Fields" writes: > On Tue, Feb 25, 2014 at 02:03:36PM -0800, Eric W. Biederman wrote: >> "J. Bruce Fields" writes: >> >> > On Mon, Feb 24, 2014 at 04:01:29PM -0800, Eric W. Biederman wrote: >> >> Miklos Szeredi writes: >> >> >> >> > >> >> > You can optimize this by including the nega

Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-26 Thread J. Bruce Fields
On Tue, Feb 25, 2014 at 02:03:36PM -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Mon, Feb 24, 2014 at 04:01:29PM -0800, Eric W. Biederman wrote: > >> Miklos Szeredi writes: > >> > >> > > >> > You can optimize this by including the negative check within the above > >> > d

Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-25 Thread Eric W. Biederman
"J. Bruce Fields" writes: > On Mon, Feb 24, 2014 at 04:01:29PM -0800, Eric W. Biederman wrote: >> Miklos Szeredi writes: >> >> > >> > You can optimize this by including the negative check within the above >> > d_locked >> > region and calling __d_drop() instead. >> >> For this patch just movi

Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-25 Thread J. Bruce Fields
On Mon, Feb 24, 2014 at 04:01:29PM -0800, Eric W. Biederman wrote: > Miklos Szeredi writes: > > > On Sat, Feb 15, 2014 at 01:39:22PM -0800, Eric W. Biederman wrote: > >> > >> Now that d_invalidate is the only caller of check_submounts_and_drop, > >> expand check_submounts_and_drop inline in d_in

Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-24 Thread Eric W. Biederman
Miklos Szeredi writes: > On Sat, Feb 15, 2014 at 01:39:22PM -0800, Eric W. Biederman wrote: >> >> Now that d_invalidate is the only caller of check_submounts_and_drop, >> expand check_submounts_and_drop inline in d_invalidate. >> >> Signed-off-by: "Eric W. Biederman" >> --- >> fs/dcache.c

Re: [PATCH 08/11] vfs: Merge check_submounts_and_drop and d_invalidate

2014-02-18 Thread Miklos Szeredi
On Sat, Feb 15, 2014 at 01:39:22PM -0800, Eric W. Biederman wrote: > > Now that d_invalidate is the only caller of check_submounts_and_drop, > expand check_submounts_and_drop inline in d_invalidate. > > Signed-off-by: "Eric W. Biederman" > --- > fs/dcache.c| 55 +++