Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-09-06 Thread Robert Richter
On 06.09.12 13:17:19, David Ahern wrote: > On 9/6/12 1:02 PM, Robert Richter wrote: > > just found your patch... I tested the patch and it runs ok with my kernel patch that checks syscall attributes for ibs. perf tools falls back and clears exclude_guest/_host bits in attr. It also should work if

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-09-06 Thread David Ahern
On 9/6/12 1:02 PM, Robert Richter wrote: David, just found your patch... On 20.07.12 17:25:53, David Ahern wrote: PEBS cannot be used with guest mode. If user adds :p modifier set exclude_guest as well. @@ -653,6 +653,9 @@ int parse_events_modifier(struct list_head *list, char *str)

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-09-06 Thread Robert Richter
David, just found your patch... On 20.07.12 17:25:53, David Ahern wrote: > PEBS cannot be used with guest mode. If user adds :p modifier set > exclude_guest as well. > @@ -653,6 +653,9 @@ int parse_events_modifier(struct list_head *list, char > *str) > eH = 0; >

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-09-06 Thread David Ahern
On 9/6/12 11:44 AM, Robert Richter wrote: David, On 06.09.12 00:07:52, Peter Zijlstra wrote: On Wed, 2012-09-05 at 09:43 -0600, David Ahern wrote: We need to require exclude_guest when using precise attribute with perf else all running VMs on Intel-based servers will crash. I do not have an AM

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-09-06 Thread Robert Richter
David, On 06.09.12 00:07:52, Peter Zijlstra wrote: > On Wed, 2012-09-05 at 09:43 -0600, David Ahern wrote: > > We need to require exclude_guest when using precise attribute with perf > > else all running VMs on Intel-based servers will crash. I do not have an > > AMD based server to even attempt

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-09-05 Thread Peter Zijlstra
On Wed, 2012-09-05 at 09:43 -0600, David Ahern wrote: > > We need to require exclude_guest when using precise attribute with perf > else all running VMs on Intel-based servers will crash. I do not have an > AMD based server to even attempt the preferred solution. I've recently gotten a machine

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-09-05 Thread David Ahern
In an attempt to jump start this thread... On 8/3/12 7:51 AM, Robert Richter wrote: On 26.07.12 10:08:29, Peter Zijlstra wrote: On Wed, 2012-07-25 at 23:16 -0600, David Ahern wrote: Peter's patch (see https://lkml.org/lkml/2012/7/9/298) changes kernel side to require the use of exclude_guest

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-08-15 Thread David Ahern
On 8/3/12 7:51 AM, Robert Richter wrote: On 26.07.12 10:08:29, Peter Zijlstra wrote: On Wed, 2012-07-25 at 23:16 -0600, David Ahern wrote: Peter's patch (see https://lkml.org/lkml/2012/7/9/298) changes kernel side to require the use of exclude_guest if the precise modifier is used, returning -

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-08-03 Thread Robert Richter
On 26.07.12 10:08:29, Peter Zijlstra wrote: > On Wed, 2012-07-25 at 23:16 -0600, David Ahern wrote: > > > Peter's patch (see https://lkml.org/lkml/2012/7/9/298) changes kernel > > side to require the use of exclude_guest if the precise modifier is > > used, returning -EOPNOTSUPP if exclude_guest

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-08-02 Thread David Ahern
Hi Peter: On 7/25/12 11:50 PM, Gleb Natapov wrote: On Wed, Jul 25, 2012 at 10:35:46PM +0200, Peter Zijlstra wrote: On Tue, 2012-07-24 at 18:15 +0200, Robert Richter wrote: thanks for this hint. On AMD cpus precise_ip maps to IBS, which does not support hardware options as perfctrs do. Thus, f

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-26 Thread Robert Richter
On 26.07.12 10:07:37, Peter Zijlstra wrote: > On Thu, 2012-07-26 at 08:50 +0300, Gleb Natapov wrote: > > The commit is 144d31e6, but it introduces hook that is used on VMX only. > > SVM does not need it to implement guest/host only counters since it > > has HW support for that in the PMU. > > Righ

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-26 Thread Gleb Natapov
On Thu, Jul 26, 2012 at 10:07:37AM +0200, Peter Zijlstra wrote: > On Thu, 2012-07-26 at 08:50 +0300, Gleb Natapov wrote: > > On Wed, Jul 25, 2012 at 10:35:46PM +0200, Peter Zijlstra wrote: > > > On Tue, 2012-07-24 at 18:15 +0200, Robert Richter wrote: > > > > David, > > > > > > > > On 24.07.12 08:

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-26 Thread Peter Zijlstra
On Wed, 2012-07-25 at 23:16 -0600, David Ahern wrote: > Peter's patch (see https://lkml.org/lkml/2012/7/9/298) changes kernel > side to require the use of exclude_guest if the precise modifier is > used, returning -EOPNOTSUPP if exclude_guest is not set. This patch goes > after the user experie

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-26 Thread Peter Zijlstra
On Thu, 2012-07-26 at 08:50 +0300, Gleb Natapov wrote: > On Wed, Jul 25, 2012 at 10:35:46PM +0200, Peter Zijlstra wrote: > > On Tue, 2012-07-24 at 18:15 +0200, Robert Richter wrote: > > > David, > > > > > > On 24.07.12 08:20:19, David Ahern wrote: > > > > On 7/23/12 12:13 PM, Arnaldo Carvalho de M

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-25 Thread Gleb Natapov
On Wed, Jul 25, 2012 at 10:35:46PM +0200, Peter Zijlstra wrote: > On Tue, 2012-07-24 at 18:15 +0200, Robert Richter wrote: > > David, > > > > On 24.07.12 08:20:19, David Ahern wrote: > > > On 7/23/12 12:13 PM, Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Jul 20, 2012 at 05:25:53PM -0600, David

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-25 Thread David Ahern
On 7/24/12 12:03 PM, Arnaldo Carvalho de Melo wrote: Em Tue, Jul 24, 2012 at 11:28:48AM -0600, David Ahern escreveu: On 7/24/12 10:15 AM, Robert Richter wrote: On AMD cpus precise_ip maps to IBS, which does not support hardware options as perfctrs do. Thus, following attr flags are not supporte

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-25 Thread Peter Zijlstra
On Tue, 2012-07-24 at 18:15 +0200, Robert Richter wrote: > David, > > On 24.07.12 08:20:19, David Ahern wrote: > > On 7/23/12 12:13 PM, Arnaldo Carvalho de Melo wrote: > > > Em Fri, Jul 20, 2012 at 05:25:53PM -0600, David Ahern escreveu: > > >> PEBS cannot be used with guest mode. If user adds :p

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-24 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 24, 2012 at 11:28:48AM -0600, David Ahern escreveu: > On 7/24/12 10:15 AM, Robert Richter wrote: > >On AMD cpus precise_ip maps to IBS, which does not support hardware > >options as perfctrs do. Thus, following attr flags are not supported: > > exclude_user, exclude_kernel, exclude_ho

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-24 Thread David Ahern
On 7/24/12 10:15 AM, Robert Richter wrote: David, On 24.07.12 08:20:19, David Ahern wrote: On 7/23/12 12:13 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 20, 2012 at 05:25:53PM -0600, David Ahern escreveu: PEBS cannot be used with guest mode. If user adds :p modifier set exclude_guest as we

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-24 Thread Robert Richter
David, On 24.07.12 08:20:19, David Ahern wrote: > On 7/23/12 12:13 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Jul 20, 2012 at 05:25:53PM -0600, David Ahern escreveu: > >> PEBS cannot be used with guest mode. If user adds :p modifier set > >> exclude_guest as well. > > > > Is this something In

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-24 Thread David Ahern
On 7/23/12 12:13 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 20, 2012 at 05:25:53PM -0600, David Ahern escreveu: PEBS cannot be used with guest mode. If user adds :p modifier set exclude_guest as well. Is this something Intel specific? Or can someone think of an arch where this limitation

Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

2012-07-23 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 20, 2012 at 05:25:53PM -0600, David Ahern escreveu: > PEBS cannot be used with guest mode. If user adds :p modifier set > exclude_guest as well. Is this something Intel specific? Or can someone think of an arch where this limitation wouldn't exist? > > Signed-off-by: David Ahern >