Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-03-05 Thread Borislav Petkov
On Wed, Mar 05, 2014 at 01:40:10PM -0500, Vivek Goyal wrote: > I thought Dave passed relevant information on bootparams and some in > cmdline (I have not looked at details). Once the EFI support is in, > kernel implementaion should do the same thing as kexec-tools is doing > to pass EFI mapping inf

Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-03-05 Thread Vivek Goyal
On Wed, Mar 05, 2014 at 05:37:22PM +0100, Borislav Petkov wrote: [..] > > > > +struct bzimage64_data { > > > > + /* > > > > +* Temporary buffer to hold bootparams buffer. This should be > > > > +* freed once the bootparam segment has been loaded. > > > > +*/ > > > > +

Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-03-05 Thread H. Peter Anvin
On 03/05/2014 08:37 AM, Borislav Petkov wrote: >> >> If the "HdrS" (0x53726448) magic number is not found at offset 0x202, >> the boot protocol version is "old". Loading an old kernel, the >> following parameters should be assumed: >> >> Image type = zImage >> initrd not supported

Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-03-05 Thread Borislav Petkov
On Fri, Feb 28, 2014 at 11:31:35AM -0500, Vivek Goyal wrote: > Thanks for taking time to review this large patchset. Sure, np. Thanks for your patience in explaining stuff which is unclear to me. > > > +struct bzimage64_data { > > > + /* > > > + * Temporary buffer to hold bootparams buffer. This

Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-02-28 Thread Vivek Goyal
On Thu, Feb 27, 2014 at 10:36:29PM +0100, Borislav Petkov wrote: Hi Boris, Thanks for taking time to review this large patchset. Please find my comments inline. [..] > > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > > index cb648c8..fa9981d 100644 > > --- a/arch/x86/kernel/M

Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-02-27 Thread Borislav Petkov
On Mon, Jan 27, 2014 at 01:57:48PM -0500, Vivek Goyal wrote: > This is loader specific code which can load bzImage and set it up for > 64bit entry. This does not take care of 32bit entry or real mode entry > yet. > > Signed-off-by: Vivek Goyal > --- checkpatch: total: 4 errors, 2 warnings, 450 l

Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-02-25 Thread Vivek Goyal
On Tue, Feb 25, 2014 at 10:38:24AM -0800, H. Peter Anvin wrote: > On 01/27/2014 10:57 AM, Vivek Goyal wrote: > > This is loader specific code which can load bzImage and set it up for > > 64bit entry. This does not take care of 32bit entry or real mode entry > > yet. > > Is there any use in that?

Re: [PATCH 08/11] kexec-bzImage: Support for loading bzImage using 64bit entry

2014-02-25 Thread H. Peter Anvin
On 01/27/2014 10:57 AM, Vivek Goyal wrote: > This is loader specific code which can load bzImage and set it up for > 64bit entry. This does not take care of 32bit entry or real mode entry > yet. Is there any use in that? Real mode entry especially is more than a bit scary when coming from another