Re: [PATCH 07/33] autonuma: mm_autonuma and task_autonuma data structures

2012-10-11 Thread Andrea Arcangeli
Hi Christoph, On Fri, Oct 12, 2012 at 12:23:17AM +, Christoph Lameter wrote: > On Thu, 11 Oct 2012, Rik van Riel wrote: > > > These statistics are updated at page fault time, I > > believe while holding the page table lock. > > > > In other words, they are in code paths where updating > > the

Re: [PATCH 07/33] autonuma: mm_autonuma and task_autonuma data structures

2012-10-11 Thread Mel Gorman
On Thu, Oct 11, 2012 at 07:15:20PM +0200, Andrea Arcangeli wrote: > On Thu, Oct 11, 2012 at 01:28:27PM +0100, Mel Gorman wrote: > > s/togehter/together/ > > Fixed. > > > > > > + * knumad_scan structure. > > > + */ > > > +struct mm_autonuma { > > > > Nit but this is very similar in principle to

Re: [PATCH 07/33] autonuma: mm_autonuma and task_autonuma data structures

2012-10-11 Thread Andrea Arcangeli
On Thu, Oct 11, 2012 at 01:28:27PM +0100, Mel Gorman wrote: > s/togehter/together/ Fixed. > > > + * knumad_scan structure. > > + */ > > +struct mm_autonuma { > > Nit but this is very similar in principle to mm_slot for transparent > huge pages. It might be worth renaming both to mm_thp_slot and