Re: [PATCH 07/28] nios2: I/O Mapping

2014-05-05 Thread Ley Foon Tan
On Fri, May 2, 2014 at 8:22 PM, Arnd Bergmann wrote: >> >> I would recommend just doing all of this in out-of-line implementations >> >> rather than macros and inline functions. >> > Okay. Will move the macros to out-of-line function. >> >> I'm start working on this and found that it is better to

Re: [PATCH 07/28] nios2: I/O Mapping

2014-05-02 Thread Arnd Bergmann
On Friday 02 May 2014 18:37:55 Ley Foon Tan wrote: > On Thu, Apr 24, 2014 at 2:02 PM, Ley Foon Tan wrote: > > On Tue, Apr 22, 2014 at 9:59 PM, Arnd Bergmann wrote: > >> On Friday 18 April 2014, Ley Foon Tan wrote: > >> > >>> + > >>> +#include > >>> + > >>> +#define IO_SPACE_LIMIT 0x > >>

Re: [PATCH 07/28] nios2: I/O Mapping

2014-05-02 Thread Ley Foon Tan
On Thu, Apr 24, 2014 at 2:02 PM, Ley Foon Tan wrote: > On Tue, Apr 22, 2014 at 9:59 PM, Arnd Bergmann wrote: >> On Friday 18 April 2014, Ley Foon Tan wrote: >> >>> + >>> +#include >>> + >>> +#define IO_SPACE_LIMIT 0x >> >> Please use 0x here, this should work for almost any PCI bus.

Re: [PATCH 07/28] nios2: I/O Mapping

2014-04-24 Thread Ley Foon Tan
On Thu, Apr 24, 2014 at 3:43 PM, Arnd Bergmann wrote: > On Thursday 24 April 2014 14:02:47 Ley Foon Tan wrote: >> >> +#define IO_SPACE_LIMIT 0x >> > >> > Please use 0x here, this should work for almost any PCI bus. >> Ah, CONFIG_PCI is not enable in nios2. So, I think IO_SPACE_LIMIT >

Re: [PATCH 07/28] nios2: I/O Mapping

2014-04-24 Thread Arnd Bergmann
On Thursday 24 April 2014 14:02:47 Ley Foon Tan wrote: > On Tue, Apr 22, 2014 at 9:59 PM, Arnd Bergmann wrote: > > On Friday 18 April 2014, Ley Foon Tan wrote: > > > >> + > >> +#include > >> + > >> +#define IO_SPACE_LIMIT 0x > > > > Please use 0x here, this should work for almost any

Re: [PATCH 07/28] nios2: I/O Mapping

2014-04-23 Thread Ley Foon Tan
On Tue, Apr 22, 2014 at 9:59 PM, Arnd Bergmann wrote: > On Friday 18 April 2014, Ley Foon Tan wrote: > >> + >> +#include >> + >> +#define IO_SPACE_LIMIT 0x > > Please use 0x here, this should work for almost any PCI bus. Ah, CONFIG_PCI is not enable in nios2. So, I think IO_SPACE_LIMI

Re: [PATCH 07/28] nios2: I/O Mapping

2014-04-22 Thread Arnd Bergmann
On Friday 18 April 2014, Ley Foon Tan wrote: > + > +#include > + > +#define IO_SPACE_LIMIT 0x Please use 0x here, this should work for almost any PCI bus. > + > +#ifndef CONFIG_CC_OPTIMIZE_FOR_SIZE > +# define __IO_USE_DUFFS > +#endif > + > +#ifdef __IO_USE_DUFFS > + > +/* Use "Duff