Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-09 Thread Mathieu Poirier
On 7 November 2017 at 03:36, Suzuki K Poulose wrote: > On 06/11/17 19:07, Mathieu Poirier wrote: >> >> On Thu, Oct 19, 2017 at 06:15:42PM +0100, Suzuki K Poulose wrote: > > > ... > >>> +/* >>> + * tmc_etr_sg_offset_to_table_index : Translate a given data @offset >>> + * to the index of the page ta

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-07 Thread Suzuki K Poulose
On 06/11/17 19:07, Mathieu Poirier wrote: On Thu, Oct 19, 2017 at 06:15:42PM +0100, Suzuki K Poulose wrote: ... +/* + * tmc_etr_sg_offset_to_table_index : Translate a given data @offset + * to the index of the page table "entry". Data pointers always have + * a fixed location, with ETR_SG_PTR

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-06 Thread Mathieu Poirier
On Thu, Oct 19, 2017 at 06:15:42PM +0100, Suzuki K Poulose wrote: > Make the ETR SG table Circular buffer so that we could start > at any of the SG pages and use the entire buffer for tracing. > This can be achieved by : > > 1) Keeping an additional LINK pointer at the very end of the > SG table,

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-02 Thread Russell King - ARM Linux
On Thu, Nov 02, 2017 at 08:40:16AM -0600, Mathieu Poirier wrote: > On 2 November 2017 at 06:00, Suzuki K Poulose wrote: > > On 01/11/17 23:47, Mathieu Poirier wrote: > >> > >> On Thu, Oct 19, 2017 at 06:15:42PM +0100, Suzuki K Poulose wrote: > >>> > >>> Make the ETR SG table Circular buffer so tha

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-02 Thread Mathieu Poirier
On 2 November 2017 at 06:00, Suzuki K Poulose wrote: > On 01/11/17 23:47, Mathieu Poirier wrote: >> >> On Thu, Oct 19, 2017 at 06:15:42PM +0100, Suzuki K Poulose wrote: >>> >>> Make the ETR SG table Circular buffer so that we could start >>> at any of the SG pages and use the entire buffer for tra

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-02 Thread Suzuki K Poulose
On 01/11/17 23:47, Mathieu Poirier wrote: On Thu, Oct 19, 2017 at 06:15:42PM +0100, Suzuki K Poulose wrote: Make the ETR SG table Circular buffer so that we could start at any of the SG pages and use the entire buffer for tracing. This can be achieved by : 1) Keeping an additional LINK pointer

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-01 Thread Mathieu Poirier
On Thu, Oct 19, 2017 at 06:15:42PM +0100, Suzuki K Poulose wrote: > Make the ETR SG table Circular buffer so that we could start > at any of the SG pages and use the entire buffer for tracing. > This can be achieved by : > > 1) Keeping an additional LINK pointer at the very end of the > SG table,

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-11-01 Thread Suzuki K Poulose
On 20/10/17 18:11, Julien Thierry wrote: +static int __maybe_unused +tmc_etr_sg_table_rotate(struct etr_sg_table *etr_table, u64 base_offset) +{ +    u32 last_entry, first_entry; +    u64 last_offset; +    struct tmc_sg_table *sg_table = etr_table->sg_table; +    sgte_t *table_ptr = sg_table->ta

Re: [PATCH 06/17] coresight: tmc: Make ETR SG table circular

2017-10-20 Thread Julien Thierry
Hi Suzuki, On 19/10/17 18:15, Suzuki K Poulose wrote: Make the ETR SG table Circular buffer so that we could start at any of the SG pages and use the entire buffer for tracing. This can be achieved by : 1) Keeping an additional LINK pointer at the very end of the SG table, i.e, after the LAST b