Re: [PATCH 06/10] perf tools: Collect other metrics in struct egroup

2020-06-29 Thread Ian Rogers
On Sun, Jun 28, 2020 at 3:06 PM Jiri Olsa wrote: > > On Fri, Jun 26, 2020 at 02:48:02PM -0700, Ian Rogers wrote: > > On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa wrote: > > > > > > Collecting other metrics in struct egroup object, > > > so we can process them later on. > > > > > > The change will p

Re: [PATCH 06/10] perf tools: Collect other metrics in struct egroup

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:48:02PM -0700, Ian Rogers wrote: > On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa wrote: > > > > Collecting other metrics in struct egroup object, > > so we can process them later on. > > > > The change will parse or 'other' metric names out of > > expression and 'resolve' t

Re: [PATCH 06/10] perf tools: Collect other metrics in struct egroup

2020-06-28 Thread Jiri Olsa
On Fri, Jun 26, 2020 at 02:06:47PM -0700, Ian Rogers wrote: SNIP > > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c > > index 85e7fa2e2707..f88fd667cc78 100644 > > --- a/tools/perf/util/metricgroup.c > > +++ b/tools/perf/util/metricgroup.c > > @@ -102,12 +102,20 @@ voi

Re: [PATCH 06/10] perf tools: Collect other metrics in struct egroup

2020-06-26 Thread Ian Rogers
On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa wrote: > > Collecting other metrics in struct egroup object, > so we can process them later on. > > The change will parse or 'other' metric names out of > expression and 'resolve' them. > > Every used expression needs to have 'metric:' prefix, > like: >

Re: [PATCH 06/10] perf tools: Collect other metrics in struct egroup

2020-06-26 Thread Ian Rogers
On Fri, Jun 26, 2020 at 12:47 PM Jiri Olsa wrote: > > Collecting other metrics in struct egroup object, > so we can process them later on. > > The change will parse or 'other' metric names out of > expression and 'resolve' them. > > Every used expression needs to have 'metric:' prefix, > like: >