Re: [PATCH 05/33] autonuma: pte_numa() and pmd_numa()

2012-10-11 Thread Mel Gorman
On Thu, Oct 11, 2012 at 06:58:47PM +0200, Andrea Arcangeli wrote: > On Thu, Oct 11, 2012 at 12:15:45PM +0100, Mel Gorman wrote: > > huh? > > > > #define _PAGE_NUMA _PAGE_PROTNONE > > > > so this is effective _PAGE_PRESENT | _PAGE_PROTNONE | _PAGE_PROTNONE > > > > I suspect you are doing this

Re: [PATCH 05/33] autonuma: pte_numa() and pmd_numa()

2012-10-11 Thread Andrea Arcangeli
On Thu, Oct 11, 2012 at 12:15:45PM +0100, Mel Gorman wrote: > huh? > > #define _PAGE_NUMA _PAGE_PROTNONE > > so this is effective _PAGE_PRESENT | _PAGE_PROTNONE | _PAGE_PROTNONE > > I suspect you are doing this because there is no requirement for > _PAGE_NUMA == _PAGE_PROTNONE for other arch