Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.

2016-06-22 Thread Joseph Myers
On Wed, 22 Jun 2016, Yury Norov wrote: > > As well as preprocessor indentation, this is missing spaces after '('; > > check for and fix that issue throughout this patch series. (There are > > only a few cases where a macro is used to construct a type / variable > > name, such as ElfW, where mi

Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.

2016-06-22 Thread Andreas Schwab
Yury Norov writes: > On Tue, Jun 21, 2016 at 10:28:40AM +, Joseph Myers wrote: >> On Tue, 21 Jun 2016, Yury Norov wrote: >> >> > +#ifdef __LP64__ >> > +#define RTLD_START RTLD_START_1("x", "3", "sp") >> > +#else >> > +#define RTLD_START RTLD_START_1("w", "2", "wsp") >> > +#endif >> >> As we

Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.

2016-06-21 Thread Yury Norov
On Tue, Jun 21, 2016 at 10:28:40AM +, Joseph Myers wrote: > On Tue, 21 Jun 2016, Yury Norov wrote: > > > +#ifdef __LP64__ > > +#define RTLD_START RTLD_START_1("x", "3", "sp") > > +#else > > +#define RTLD_START RTLD_START_1("w", "2", "wsp") > > +#endif > > As well as preprocessor indentation,

Re: [PATCH 05/27] [AARCH64] Use PTR_REG in crti.S.

2016-06-21 Thread Joseph Myers
On Tue, 21 Jun 2016, Yury Norov wrote: > +#ifdef __LP64__ > +#define RTLD_START RTLD_START_1("x", "3", "sp") > +#else > +#define RTLD_START RTLD_START_1("w", "2", "wsp") > +#endif As well as preprocessor indentation, this is missing spaces after '('; check for and fix that issue throughout this