Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-08 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 08, 2012 at 08:12:53AM -0700, Arnaldo Carvalho de Melo escreveu: > Trying to figure out when to apply this patch, as it should fix the > problem one experiences right after applying the first patch of your > series plus the small fix you sent before this one, and it is not > applying...

Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-08 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 08, 2012 at 11:37:31PM +0900, Namhyung Kim escreveu: > On Sat, 8 Sep 2012 05:50:59 -0700, Arnaldo Carvalho de Melo wrote: > > well, you can, but that one is buggy and you will not be able to test > > 'perf diff' at all... > > I posted the fix right before, and you will also need patch

Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-08 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 08, 2012 at 11:37:31PM +0900, Namhyung Kim escreveu: > I posted the fix right before, and you will also need patch below for > fixing broken "baseline" output. Ok, folding this as well, as it should fix the problem I just reported, sorry mid air collision report (crossed reports, bugzi

Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-08 Thread Namhyung Kim
Hi Jiri, On Sat, 8 Sep 2012 05:50:59 -0700, Arnaldo Carvalho de Melo wrote: > Em Sat, Sep 08, 2012 at 02:35:14PM +0200, Jiri Olsa escreveu: >> On Fri, Sep 07, 2012 at 11:55:02AM +0900, Namhyung Kim wrote: >> > Hi, Jiri >> > >> > On Thu, 6 Sep 2012 17:46:59 +0200, Jiri Olsa wrote: >> > > Currentl

Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-08 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 08, 2012 at 02:35:14PM +0200, Jiri Olsa escreveu: > On Fri, Sep 07, 2012 at 11:55:02AM +0900, Namhyung Kim wrote: > > Hi, Jiri > > > > On Thu, 6 Sep 2012 17:46:59 +0200, Jiri Olsa wrote: > > > Currently for any of the data columns (like Overhead/Period..) in > > > stdio ui, there's se

Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-08 Thread Jiri Olsa
On Fri, Sep 07, 2012 at 11:55:02AM +0900, Namhyung Kim wrote: > Hi, Jiri > > On Thu, 6 Sep 2012 17:46:59 +0200, Jiri Olsa wrote: > > Currently for any of the data columns (like Overhead/Period..) in > > stdio ui, there's separate code to print header/dots/value scattered > > along the display cod

Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-07 Thread Jiri Olsa
On Fri, Sep 07, 2012 at 11:55:02AM +0900, Namhyung Kim wrote: > Hi, Jiri > > On Thu, 6 Sep 2012 17:46:59 +0200, Jiri Olsa wrote: > > Currently for any of the data columns (like Overhead/Period..) in > > stdio ui, there's separate code to print header/dots/value scattered > > along the display cod

Re: [PATCH 05/12] perf diff: Refactor stdio ui data columns output

2012-09-06 Thread Namhyung Kim
Hi, Jiri On Thu, 6 Sep 2012 17:46:59 +0200, Jiri Olsa wrote: > Currently for any of the data columns (like Overhead/Period..) in > stdio ui, there's separate code to print header/dots/value scattered > along the display code path. > > Adding hists_stdio_column struct to centralize all info needed