Re: [PATCH 04/79] ext4: split inode_operations for encrypted symlinks off the rest

On Mon, May 4, 2015 at 10:21 PM, Al Viro wrote: > } else if (S_ISLNK(inode->i_mode)) { > - if (ext4_inode_is_fast_symlink(inode) && > - !ext4_encrypted_inode(inode)) { > + if (ext4_encrypted_inode(inode)) { > +#ifdef CONFIG_EXT4_FS_ENCRYPTION >

Re: [PATCH 04/79] ext4: split inode_operations for encrypted symlinks off the rest

On Tue, May 05, 2015 at 08:01:52AM -0700, Linus Torvalds wrote: > Ugh. Could we aim to *not* add code like this. > > Instead, just declare (but don't define) the > ext4_encrypted_symlink_inode_operations thing, so that *if* somebody > uses it they get a link error, and make sure that > "ext4_encry

Re: [PATCH 04/79] ext4: split inode_operations for encrypted symlinks off the rest

On Tue 05-05-15 06:21:38, Al Viro wrote: > From: Al Viro > > Signed-off-by: Al Viro Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/ext4.h| 1 + > fs/ext4/inode.c | 10 -- > fs/ext4/namei.c