* Rik van Riel [2018-06-04 10:37:30]:
> On Mon, 2018-06-04 at 05:59 -0700, Srikar Dronamraju wrote:
> > * Peter Zijlstra [2018-06-04 14:23:36]:
> >
> > > > - if (ng->active_nodes > 1 &&
> > > > numa_is_active_node(env.dst_nid, ng))
> > > > - sched_setnuma(p,
On Mon, 2018-06-04 at 05:59 -0700, Srikar Dronamraju wrote:
> * Peter Zijlstra [2018-06-04 14:23:36]:
>
> > OK, the above matches the description, but I'm puzzled by the
> > remainder:
> >
> > >
> > > - if (ng->active_nodes > 1 &&
> > > numa_is_active_node(env.dst_nid, ng))
> > > -
* Peter Zijlstra [2018-06-04 15:39:53]:
> > >
> > > That seems to entirely loose the active_node thing, or are you saying
> > > best_cpu already includes that? (Changelog could use a little help there
> > > I suppose)
> >
> > I think checking for active_nodes before calling sched_setnuma was a
>
On Mon, Jun 04, 2018 at 05:59:40AM -0700, Srikar Dronamraju wrote:
> * Peter Zijlstra [2018-06-04 14:23:36]:
>
> > OK, the above matches the description, but I'm puzzled by the remainder:
> >
> > >
> > > - if (ng->active_nodes > 1 && numa_is_active_node(env.dst_nid,
> > > ng))
> > > -
* Peter Zijlstra [2018-06-04 14:23:36]:
> OK, the above matches the description, but I'm puzzled by the remainder:
>
> >
> > - if (ng->active_nodes > 1 && numa_is_active_node(env.dst_nid,
> > ng))
> > - sched_setnuma(p, env.dst_nid);
> > + if (nid != p->numa
* Peter Zijlstra [2018-06-04 14:18:00]:
> On Mon, Jun 04, 2018 at 03:30:13PM +0530, Srikar Dronamraju wrote:
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index ea32a66..94091e6 100644
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -1725,8 +1725,9 @@ static in
On Mon, Jun 04, 2018 at 03:30:13PM +0530, Srikar Dronamraju wrote:
> @@ -1785,15 +1786,13 @@ static int task_numa_migrate(struct task_struct *p)
>* trying for a better one later. Do not set the preferred node here.
>*/
> if (p->numa_group) {
> - struct numa_group *
On Mon, Jun 04, 2018 at 03:30:13PM +0530, Srikar Dronamraju wrote:
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index ea32a66..94091e6 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -1725,8 +1725,9 @@ static int task_numa_migrate(struct task_struct *p)
>*
8 matches
Mail list logo