Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

On Tue, Nov 6, 2018 at 11:07 PM Jacek Anaszewski wrote: > +#define LED_FUNCTION_DISK "disk" I recently added triggers for "disk-read" and "disk-write". This was because the D-Link DNS-313 does have dedicated LEDs for each usecase, and so does DIR-685. So I think you may need LED_FUNCTION_DISK_R

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

Hi Vesa, On 11/12/2018 01:25 AM, Vesa Jääskeläinen wrote: > Hi Jacek, > > On 07/11/2018 0.07, Jacek Anaszewski wrote: >> Add common LED function definitions for use in Device Tree. >> The function names were extracted from existing dts files >> after eliminating oddities. > > Is your intent here

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

Hi Jacek, On 07/11/2018 0.07, Jacek Anaszewski wrote: Add common LED function definitions for use in Device Tree. The function names were extracted from existing dts files after eliminating oddities. Is your intent here is to standardize the function definitions and to aid in that is to speci

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

On 11/11/2018 09:20 PM, Pavel Machek wrote: > Hi! > +#define LED_FUNCTION_BACKLIGHT "backlight" +#define LED_FUNCTION_BACKLIGHT_CLUSTER "backlight_cluster" >>> >>> Sounds like one of backlight and backlight_cluster should be deprecated? >> >> I think so. > > Agreed. > +#define LED

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

Hi! > >> +#define LED_FUNCTION_BACKLIGHT "backlight" > >> +#define LED_FUNCTION_BACKLIGHT_CLUSTER "backlight_cluster" > > > > Sounds like one of backlight and backlight_cluster should be deprecated? > > I think so. Agreed. > >> +#define LED_FUNCTION_DEBUG "debug" > >> +#define LED_FUNCTION_DIA

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

Hi Pavel, Thanks for the review. On 11/11/2018 12:31 PM, Pavel Machek wrote: > Hi! > >> Add common LED function definitions for use in Device Tree. >> The function names were extracted from existing dts files >> after eliminating oddities. > > Thanks for doing this. > >> diff --git a/include/d

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

Hi! > Add common LED function definitions for use in Device Tree. > The function names were extracted from existing dts files > after eliminating oddities. Thanks for doing this. > diff --git a/include/dt-bindings/leds/functions.h > b/include/dt-bindings/leds/functions.h > new file mode 100644

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

Hi Rob, Thanks for the review. On 11/08/2018 04:13 PM, Rob Herring wrote: > On Tue, Nov 6, 2018 at 4:07 PM Jacek Anaszewski > wrote: >> >> Add common LED function definitions for use in Device Tree. >> The function names were extracted from existing dts files >> after eliminating oddities. >> >>

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

On Tue, Nov 6, 2018 at 4:07 PM Jacek Anaszewski wrote: > > Add common LED function definitions for use in Device Tree. > The function names were extracted from existing dts files > after eliminating oddities. > > Signed-off-by: Jacek Anaszewski > Cc: Baolin Wang > Cc: Daniel Mack > Cc: Dan Murp

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

Hi Michal On 11/07/2018 09:36 AM, Vokáč Michal wrote: > On 6.11.2018 23:07, Jacek Anaszewski wrote: >> Add common LED function definitions for use in Device Tree. >> The function names were extracted from existing dts files >> after eliminating oddities. >> >> Signed-off-by: Jacek Anaszewski >> C

Re: [PATCH 03/24] leds: dt-bindings: Add LED_FUNCTION definitions

On 6.11.2018 23:07, Jacek Anaszewski wrote: > Add common LED function definitions for use in Device Tree. > The function names were extracted from existing dts files > after eliminating oddities. > > Signed-off-by: Jacek Anaszewski > Cc: Baolin Wang > Cc: Daniel Mack > Cc: Dan Murphy > Cc: Lin