Re: [PATCH 03/19] x86/dumpstack: remove unnecessary stack pointer arguments

2016-07-21 Thread Brian Gerst
On Thu, Jul 21, 2016 at 9:41 PM, Josh Poimboeuf wrote: > On Thu, Jul 21, 2016 at 02:56:52PM -0700, Andy Lutomirski wrote: >> On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf wrote: >> > When calling show_stack_log_lvl() or dump_trace() with a regs argument, >> > providing a stack pointer or frame

Re: [PATCH 03/19] x86/dumpstack: remove unnecessary stack pointer arguments

2016-07-21 Thread Andy Lutomirski
On Thu, Jul 21, 2016 at 6:41 PM, Josh Poimboeuf wrote: > On Thu, Jul 21, 2016 at 02:56:52PM -0700, Andy Lutomirski wrote: >> On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf wrote: >> > When calling show_stack_log_lvl() or dump_trace() with a regs argument, >> > providing a stack pointer or frame

Re: [PATCH 03/19] x86/dumpstack: remove unnecessary stack pointer arguments

2016-07-21 Thread Josh Poimboeuf
On Thu, Jul 21, 2016 at 02:56:52PM -0700, Andy Lutomirski wrote: > On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf wrote: > > When calling show_stack_log_lvl() or dump_trace() with a regs argument, > > providing a stack pointer or frame pointer is redundant. > > > > > diff --git a/arch/x86/kernel

Re: [PATCH 03/19] x86/dumpstack: remove unnecessary stack pointer arguments

2016-07-21 Thread Andy Lutomirski
On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf wrote: > When calling show_stack_log_lvl() or dump_trace() with a regs argument, > providing a stack pointer or frame pointer is redundant. > > diff --git a/arch/x86/kernel/dumpstack_32.c b/arch/x86/kernel/dumpstack_32.c > index 358fe1c..c533b8b 100