Re: [PATCH 03/15] tty: serial: 8250_core: add run time pm

2014-09-01 Thread Sebastian Andrzej Siewior
On 08/20/2014 11:39 AM, Frans Klaver wrote: >>> static int serial8250_get_poll_char(struct uart_port *port) >>> { >>> - unsigned char lsr = serial_port_in(port, UART_LSR); >>> + unsigned char lsr; >>> + int status; >>> + >>> + serial8250_rpm_get(up); >> >> or up won't be defined below. Y

Re: [PATCH 03/15] tty: serial: 8250_core: add run time pm

2014-08-20 Thread Frans Klaver
On Wed, Aug 20, 2014 at 11:23:21AM +0200, Frans Klaver wrote: > Hi, > > On Fri, Aug 15, 2014 at 07:42:31PM +0200, Sebastian Andrzej Siewior wrote: > > --- a/drivers/tty/serial/8250/8250_core.c > > +++ b/drivers/tty/serial/8250/8250_core.c > > @@ -1899,12 +1984,22 @@ static void wait_for_xmitr(stru

Re: [PATCH 03/15] tty: serial: 8250_core: add run time pm

2014-08-20 Thread Frans Klaver
Hi, On Fri, Aug 15, 2014 at 07:42:31PM +0200, Sebastian Andrzej Siewior wrote: > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -1899,12 +1984,22 @@ static void wait_for_xmitr(struct uart_8250_port *up, > int bits) > > static int serial8250_get_poll_