Re: [PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-23 Thread David Howells
Al Viro wrote: > On Sat, Oct 20, 2018 at 02:10:52AM +0100, David Howells wrote: > > Renumber the ITER_* constants in uio.h to be contiguous to make comparing > > them more efficient in a switch-statement. > > Are you sure that they *are* more efficient that way? Some of those paths > are fairly

Re: [PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-22 Thread David Howells
Al Viro wrote: > > Renumber the ITER_* constants in uio.h to be contiguous to make comparing > > them more efficient in a switch-statement. > > Are you sure that they *are* more efficient that way? Some of those paths > are fairly hot, so much that I would really like to see profiles before > a

Re: [PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

2018-10-19 Thread Al Viro
On Sat, Oct 20, 2018 at 02:10:52AM +0100, David Howells wrote: > Renumber the ITER_* constants in uio.h to be contiguous to make comparing > them more efficient in a switch-statement. Are you sure that they *are* more efficient that way? Some of those paths are fairly hot, so much that I would re