RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-13 Thread Liang, Kan
> Em Fri, Oct 13, 2017 at 12:55:34PM +, Liang, Kan escreveu: > > > Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > > > > From: Kan Liang > > > > > > > > Perf record can switch output. The new output should only store > > > > the data after switching. However, in overw

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-13 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 13, 2017 at 12:55:34PM +, Liang, Kan escreveu: > > Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > > > From: Kan Liang > > > > > > Perf record can switch output. The new output should only store the > > > data after switching. However, in overwrite backwar

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-13 Thread Liang, Kan
> Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > > From: Kan Liang > > > > Perf record can switch output. The new output should only store the > > data after switching. However, in overwrite backward mode, the new > > output still have the data from old output. > > > > A

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-12 Thread Wangnan (F)
On 2017/10/12 20:49, Liang, Kan wrote: From 8b058ea6977a97e5705aa2f64bdd014fd76d1247 Mon Sep 17 00:00:00 2001 From: Kan Liang Date: Wed, 11 Oct 2017 07:39:34 -0700 Subject: [PATCH] perf tool: fix: Don't discard prev in backward mode Perf record can switch output. The new output should onl

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-12 Thread Liang, Kan
> > From 8b058ea6977a97e5705aa2f64bdd014fd76d1247 Mon Sep 17 > 00:00:00 > > 2001 > > From: Kan Liang > > Date: Wed, 11 Oct 2017 07:39:34 -0700 > > Subject: [PATCH] perf tool: fix: Don't discard prev in backward mode > > > > Perf record can switch output. The new output should only store the > > d

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-11 Thread Wangnan (F)
On 2017/10/11 22:57, Liang, Kan wrote: If you really want to avoid record duplication, you need to changes record__mmap_read()'s logic. Now it complains "failed to keep up with mmap data" and avoid dumping data when size of newly generated data is larger than the size of the ring buffer. It is

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-11 Thread Liang, Kan
> > >> > > >>> If you really want to avoid record duplication, you need to > > >>> changes record__mmap_read()'s logic. Now it complains "failed to > > >>> keep up with mmap data" and avoid dumping data when size of newly > > >>> generated data is larger than the size of the ring buffer. It is > >

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Liang, Kan
> >> > >>> If you really want to avoid record duplication, you need to changes > >>> record__mmap_read()'s > >>> logic. Now it complains "failed to keep up with mmap data" and avoid > >>> dumping data when > >>> size of newly generated data is larger than the size of the ring > >>> buffer. It is re

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Wangnan (F)
On 2017/10/11 3:50, Liang, Kan wrote: On 2017/10/11 2:23, Wangnan (F) wrote: On 2017/10/11 1:20, kan.li...@intel.com wrote: From: Kan Liang Perf record can switch output. The new output should only store the data after switching. However, in overwrite backward mode, the new output still ha

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Liang, Kan
> On 2017/10/11 2:23, Wangnan (F) wrote: > > > > > > On 2017/10/11 1:20, kan.li...@intel.com wrote: > >> From: Kan Liang > >> > >> Perf record can switch output. The new output should only store the data > >> after switching. However, in overwrite backward mode, the new output > >> still have the

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Liang, Kan
> > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > > index 33b8837..7d23cf5 100644 > > --- a/tools/perf/util/evlist.c > > +++ b/tools/perf/util/evlist.c > > @@ -742,13 +742,25 @@ static int > > rb_find_range(void *data, int mask, u64 head, u64 old, > > u64 *start, u6

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Wangnan (F)
On 2017/10/11 2:23, Wangnan (F) wrote: On 2017/10/11 1:20, kan.li...@intel.com wrote: From: Kan Liang Perf record can switch output. The new output should only store the data after switching. However, in overwrite backward mode, the new output still have the data from old output. At the e

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Wangnan (F)
On 2017/10/11 1:20, kan.li...@intel.com wrote: From: Kan Liang Perf record can switch output. The new output should only store the data after switching. However, in overwrite backward mode, the new output still have the data from old output. At the end of mmap_read, the position of processed

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Liang, Kan
> Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > > From: Kan Liang > > > > Perf record can switch output. The new output should only store the > > data after switching. However, in overwrite backward mode, the new > > output still have the data from old output. > > > > A

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-10 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > From: Kan Liang > > Perf record can switch output. The new output should only store the data > after switching. However, in overwrite backward mode, the new output > still have the data from old output. > > At the end of m