Re: [PATCH 01/14] asmlinkage, kvm: Make kvm_rebooting visible

2014-02-10 Thread Andrew Morton
On Sat, 8 Feb 2014 08:51:57 +0100 Andi Kleen wrote: > kvm_rebooting is referenced from assembler code, thus > needs to be visible. So I read the gcc page and looked at the __visible definition but I still don't really get it. What goes wrong if the __visible isn't present on these referenced-f

Re: [PATCH 01/14] asmlinkage, kvm: Make kvm_rebooting visible

2014-02-08 Thread Paolo Bonzini
Il 08/02/2014 08:51, Andi Kleen ha scritto: kvm_rebooting is referenced from assembler code, thus needs to be visible. Cc: g...@redhat.com Cc: pbonz...@redhat.com Cc: k...@vger.kernel.org Signed-off-by: Andi Kleen --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d