Re: [PATCH 01/13] nvdimm: Use more typical whitespace

2019-09-16 Thread Christoph Hellwig
On Thu, Sep 12, 2019 at 08:01:45AM -0700, Joe Perches wrote: > On Thu, 2019-09-12 at 05:17 -0700, Christoph Hellwig wrote: > > Instead of arguing what is better just stick to what the surrounding > > code does. > > That's not always feasible nor readable. > > Especially for the logic inversion bl

Re: [PATCH 01/13] nvdimm: Use more typical whitespace

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 05:17 -0700, Christoph Hellwig wrote: > Instead of arguing what is better just stick to what the surrounding > code does. That's not always feasible nor readable. Especially for the logic inversion blocks where the existing code does unreadable and error prone things like hi

Re: [PATCH 01/13] nvdimm: Use more typical whitespace

2019-09-12 Thread Christoph Hellwig
> static void append_badrange_entry(struct badrange *badrange, > - struct badrange_entry *bre, u64 addr, u64 length) > + struct badrange_entry *bre, u64 addr, u64 > length) Please stop sending this kind of crap. Two tabs are a very common style used in