Re: [PATCH 01/10] perf/core, x86: Add PERF_SAMPLE_LBR_TOS

2019-10-08 Thread Peter Zijlstra
On Tue, Oct 08, 2019 at 11:25:01AM -0400, Liang, Kan wrote: > > The perf tool bloody sets the perf_event_attr::branch_sample_type value! > > Of course it knows to expect the TOS field when it asks for it in the > > first place. > > > > Users may generate the perf.data on one machine, and parse th

Re: [PATCH 01/10] perf/core, x86: Add PERF_SAMPLE_LBR_TOS

2019-10-08 Thread Liang, Kan
On 10/8/2019 10:38 AM, Peter Zijlstra wrote: On Tue, Oct 08, 2019 at 09:53:24AM -0400, Liang, Kan wrote: On 10/8/2019 4:31 AM, Peter Zijlstra wrote: On Mon, Oct 07, 2019 at 10:59:01AM -0700, kan.li...@linux.intel.com wrote: diff --git a/include/linux/perf_event.h b/include/linux/perf_even

Re: [PATCH 01/10] perf/core, x86: Add PERF_SAMPLE_LBR_TOS

2019-10-08 Thread Peter Zijlstra
On Tue, Oct 08, 2019 at 09:53:24AM -0400, Liang, Kan wrote: > > > On 10/8/2019 4:31 AM, Peter Zijlstra wrote: > > On Mon, Oct 07, 2019 at 10:59:01AM -0700, kan.li...@linux.intel.com wrote: > > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > > > index 61448c19a132..ee9ef0c

Re: [PATCH 01/10] perf/core, x86: Add PERF_SAMPLE_LBR_TOS

2019-10-08 Thread Liang, Kan
On 10/8/2019 4:31 AM, Peter Zijlstra wrote: On Mon, Oct 07, 2019 at 10:59:01AM -0700, kan.li...@linux.intel.com wrote: diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 61448c19a132..ee9ef0c4cb08 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h

Re: [PATCH 01/10] perf/core, x86: Add PERF_SAMPLE_LBR_TOS

2019-10-08 Thread Peter Zijlstra
On Mon, Oct 07, 2019 at 10:59:01AM -0700, kan.li...@linux.intel.com wrote: > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index 61448c19a132..ee9ef0c4cb08 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -100,6 +100,7 @@ struct perf_raw_rec