Re: [PATCH 0/8] workqueue: advance concurrency management

2013-04-20 Thread Lai Jiangshan
On Sat, Apr 20, 2013 at 2:11 AM, Tejun Heo wrote: > Hey, > > On Fri, Apr 19, 2013 at 06:10:57AM +0800, Lai Jiangshan wrote: >> Ping. > > Sorry, I've been at collab summit / lsf. Plus, it's a bit too late > for for-3.10 anyway. Anyways, after glancing over it, here are my > preliminary thoughts.

Re: [PATCH 0/8] workqueue: advance concurrency management

2013-04-19 Thread Tejun Heo
Hey, On Fri, Apr 19, 2013 at 06:10:57AM +0800, Lai Jiangshan wrote: > Ping. Sorry, I've been at collab summit / lsf. Plus, it's a bit too late for for-3.10 anyway. Anyways, after glancing over it, here are my preliminary thoughts. The first one looks good but I'm not sure about dropping nr_run

Re: [PATCH 0/8] workqueue: advance concurrency management

2013-04-18 Thread Lai Jiangshan
Ping. On Mon, Apr 15, 2013 at 12:41 AM, Lai Jiangshan wrote: > I found the early-increasing nr_running in wq_worker_waking_up() is useless > in many cases. it tries to avoid waking up idle workers for pending work item. > but delay increasing nr_running does not increase waking up idle workers. >