Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/22/20 3:26 PM, Kurt Van Dijck wrote: > On ma, 22 jun 2020 14:54:15 +0200, Marc Kleine-Budde wrote: >> On 6/22/20 2:43 PM, Kurt Van Dijck wrote: >>> I get RX-0: FIFO overflows in listen-only mode (back-to-back burst of >>> the single other node). >> >> Single other node? Who's ACKing the CAN fr

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
On ma, 22 jun 2020 14:54:15 +0200, Marc Kleine-Budde wrote: > On 6/22/20 2:43 PM, Kurt Van Dijck wrote: > > I get RX-0: FIFO overflows in listen-only mode (back-to-back burst of > > the single other node). > > Single other node? Who's ACKing the CAN frames? hence the back-to-back burst. > > > T

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/22/20 2:43 PM, Kurt Van Dijck wrote: > I get RX-0: FIFO overflows in listen-only mode (back-to-back burst of > the single other node). Single other node? Who's ACKing the CAN frames? > The SPI peripheral does not use DMA :-(. The SPI messages are quite small, so DMA wont help either. Gettin

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
Marc, I get RX-0: FIFO overflows in listen-only mode (back-to-back burst of the single other node). The SPI peripheral does not use DMA :-(. Do you have, by accident, some freescale SPI fixes lying around? It's not the biggest problem on my side, but is proves the system not being guarded against

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
vger.kernel.org > Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 > Thunderbird/68.9.0 > > On 6/22/20 12:25 PM, Kurt Van Dijck wrote: > > I got my board up with a 5.7, despite device-tree problems comp

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/18/20 10:55 AM, Manivannan Sadhasivam wrote: > So how should we proceed from here? It is okay for me to work on adding some > features and also fixing the issues you've reported so far. But I want to > reach > a consensus before moving forward. > > If you think that it makes sense to go with

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/18/20 2:06 PM, Manivannan Sadhasivam wrote: >> https://github.com/marckleinebudde/linux/commits/v5.6-rpi/mcp25xxfd-20200607-41 >> > > Tested this version on my board with MCP2518FD and it works fine. I'm okay > with > moving forward with your version and would like to contribute. Please let

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Marc Kleine-Budde
On 6/22/20 12:25 PM, Kurt Van Dijck wrote: > I got my board up with a 5.7, despite device-tree problems completely > unrelated to CAN. \o/ > It seems to work well with a fully-loaded CAN bus (cangen -g0 ...). > So that is a real improvement. Can I add your Tested-by? > I will need to add the li

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-22 Thread Kurt Van Dijck
Hey Marc, On do, 18 jun 2020 14:35:28 +0200, Marc Kleine-Budde wrote: > On 6/18/20 2:30 PM, Kurt Van Dijck wrote: > > On do, 18 jun 2020 00:36:29 +0200, Marc Kleine-Budde wrote: > >> On 6/17/20 6:59 PM, Kurt Van Dijck wrote: > >>> I'm in the process of getting a Variscite imx8m mini SOM online, wi

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-19 Thread Manivannan Sadhasivam
On Thu, Jun 18, 2020 at 02:25:33PM +0530, Manivannan Sadhasivam wrote: > Hi, > > On 0611, Marc Kleine-Budde wrote: > > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > > Hello, > > > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > > Controller with MCP2517FD

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-18 Thread Marc Kleine-Budde
On 6/18/20 2:30 PM, Kurt Van Dijck wrote: > On do, 18 jun 2020 00:36:29 +0200, Marc Kleine-Budde wrote: >> On 6/17/20 6:59 PM, Kurt Van Dijck wrote: >>> I'm in the process of getting a Variscite imx8m mini SOM online, with >> >> Have your heard about the imx8m plus? It has CAN cores! We have a boar

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-18 Thread Kurt Van Dijck
On do, 18 jun 2020 00:36:29 +0200, Marc Kleine-Budde wrote: > On 6/17/20 6:59 PM, Kurt Van Dijck wrote: > > I'm in the process of getting a Variscite imx8m mini SOM online, with > > Have your heard about the imx8m plus? It has CAN cores! We have a board in the > office to play with. :) > > > MCP2

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-18 Thread Manivannan Sadhasivam
Hi, On 0611, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspired (or taken) from th

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-18 Thread Manivannan Sadhasivam
Hi, On 0611, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspired (or taken) from th

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-17 Thread Marc Kleine-Budde
On 6/17/20 6:59 PM, Kurt Van Dijck wrote: > I'm in the process of getting a Variscite imx8m mini SOM online, with Have your heard about the imx8m plus? It has CAN cores! We have a board in the office to play with. :) > MCP2517FD. The 4.19 kernel that comes with it, has a driver that is You shall

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-17 Thread Kurt Van Dijck
On do, 11 jun 2020 18:26:19 +0200, Marc Kleine-Budde wrote: > On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > > Hello, > > > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > > Controller with MCP2517FD as the target controller version. This series is > > mostly inspir

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-12 Thread Marc Kleine-Budde
On 6/11/20 10:30 PM, Marc Kleine-Budde wrote: > On 6/11/20 6:26 PM, Marc Kleine-Budde wrote: >> I initially started looking at Martin's driver and it was not using several >> modern CAN driver infrastructures. I then posted some cleanup patches but >> Martin >> was not working on the driver any mo

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-11 Thread Marc Kleine-Budde
On 6/11/20 6:26 PM, Marc Kleine-Budde wrote: > I initially started looking at Martin's driver and it was not using several > modern CAN driver infrastructures. I then posted some cleanup patches but > Martin > was not working on the driver any more. Then I decided to rewrite the driver, > that is

Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

2020-06-11 Thread Marc Kleine-Budde
On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote: > Hello, > > This series adds CAN network driver support for Microchip MCP25XXFD CAN > Controller with MCP2517FD as the target controller version. This series is > mostly inspired (or taken) from the previous iterations posted by Martin > Sperl. >