Re: [PATCH 0/4] nvme-pci: support device coredump

2019-05-04 Thread Akinobu Mita
2019年5月4日(土) 18:40 Minwoo Im : > > Hi Akinobu, > > On 5/4/19 1:20 PM, Akinobu Mita wrote: > > 2019年5月3日(金) 21:20 Christoph Hellwig : > >> > >> On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote: > >>> Could you actually explain how the rest is useful? I personally have > >>> never encounte

Re: [PATCH 0/4] nvme-pci: support device coredump

2019-05-04 Thread Minwoo Im
Hi Akinobu, On 5/4/19 1:20 PM, Akinobu Mita wrote: 2019年5月3日(金) 21:20 Christoph Hellwig : On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote: Could you actually explain how the rest is useful? I personally have never encountered an issue where knowing these values would have helped:

Re: [PATCH 0/4] nvme-pci: support device coredump

2019-05-03 Thread Akinobu Mita
2019年5月3日(金) 21:20 Christoph Hellwig : > > On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote: > > Could you actually explain how the rest is useful? I personally have > > never encountered an issue where knowing these values would have helped: > > every device timeout always needed device

Re: [PATCH 0/4] nvme-pci: support device coredump

2019-05-03 Thread Christoph Hellwig
On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote: > Could you actually explain how the rest is useful? I personally have > never encountered an issue where knowing these values would have helped: > every device timeout always needed device specific internal firmware > logs in my experien

Re: [PATCH 0/4] nvme-pci: support device coredump

2019-05-03 Thread Keith Busch
On Fri, May 03, 2019 at 12:38:08PM +0900, Akinobu Mita wrote: > 2019年5月2日(木) 22:03 Keith Busch : > > On Thu, May 02, 2019 at 05:59:17PM +0900, Akinobu Mita wrote: > > > This enables to capture snapshot of controller information via device > > > coredump machanism, and it helps diagnose and debug is

Re: [PATCH 0/4] nvme-pci: support device coredump

2019-05-02 Thread Akinobu Mita
2019年5月2日(木) 22:03 Keith Busch : > > On Thu, May 02, 2019 at 05:59:17PM +0900, Akinobu Mita wrote: > > This enables to capture snapshot of controller information via device > > coredump machanism, and it helps diagnose and debug issues. > > > > The nvme device coredump is triggered before resetting

Re: [PATCH 0/4] nvme-pci: support device coredump

2019-05-02 Thread Keith Busch
On Thu, May 02, 2019 at 05:59:17PM +0900, Akinobu Mita wrote: > This enables to capture snapshot of controller information via device > coredump machanism, and it helps diagnose and debug issues. > > The nvme device coredump is triggered before resetting the controller > caused by I/O timeout, and