Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-10-02 Thread Rajat Jain
Hi Wolfram, Thanks a lot for your review and comments. I understand and will update with those APIs and send out a V2. Thanks & Best Regards, Rajat Jain On Wed, Oct 1, 2014 at 11:34 PM, Wolfram Sang wrote: > >> I understand and agree. In fact in the internal version of this driver >> (that I h

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-10-01 Thread Wolfram Sang
> I understand and agree. In fact in the internal version of this driver > (that I have not yet sent out for review), we do have APIs added > similar to what you mention above. Currently I have APIs that: > - Enable / Disable PCIe links. > - Change the upstream port. > - Enable / Disable Non-trans

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-10-01 Thread Rajat Jain
Hello, On Wed, Oct 1, 2014 at 12:29 AM, Wolfram Sang wrote: > >> === >> .. >> >> +0. Why have an I2C interface to a PCIe switch? >> +~~ >> +Other than the regular PCI express interface, most mo

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-10-01 Thread Wolfram Sang
> === > .. > > +0. Why have an I2C interface to a PCIe switch? > +~~ > +Other than the regular PCI express interface, most modern PCIe switches (e.g. > +from IDT and PLX) have an I2C based seco

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-09-30 Thread Greg Kroah-Hartman
On Tue, Sep 30, 2014 at 02:35:51PM -0700, Guenter Roeck wrote: > On Tue, Sep 30, 2014 at 11:13:39PM +0200, Wolfram Sang wrote: > > > > > > Since this is a driver for a PCIe switch, I currently put it under > > > > /driver/pci/. > > > > I'm very open to suggestions for moving this around (Does int

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-09-30 Thread Guenter Roeck
On Tue, Sep 30, 2014 at 11:13:39PM +0200, Wolfram Sang wrote: > > > > Since this is a driver for a PCIe switch, I currently put it under > > > /driver/pci/. > > > I'm very open to suggestions for moving this around (Does introducing > > > drivers/pci/switch/ seem any better?). Especially I can se

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-09-30 Thread Rajat Jain
Hello, On Tue, Sep 30, 2014 at 2:13 PM, Wolfram Sang wrote: > >> > Since this is a driver for a PCIe switch, I currently put it under >> > /driver/pci/. >> > I'm very open to suggestions for moving this around (Does introducing >> > drivers/pci/switch/ seem any better?). Especially I can see tha

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-09-30 Thread Wolfram Sang
> > Since this is a driver for a PCIe switch, I currently put it under > > /driver/pci/. > > I'm very open to suggestions for moving this around (Does introducing > > drivers/pci/switch/ seem any better?). Especially I can see that the > > drivers/pci/Kconfig appears under "Bus Options" in the ma

Re: [PATCH 0/4] Driver for talking to PLX PEX8xxx PCIe switch over I2C

2014-09-30 Thread Bjorn Helgaas
[+cc Wolfram] On Mon, Sep 29, 2014 at 10:46 PM, Rajat Jain wrote: > Most of the PLX PCI Express switches (and also switches from other vendors > such > IDT) provide an I2C based secondary interface to access and program the > switch. > This can be used to program the switch in situations where