Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-15 Thread Sergey Senozhatsky
On (07/15/15 09:24), Minchan Kim wrote: > On Wed, Jul 15, 2015 at 09:21:06AM +0900, Sergey Senozhatsky wrote: > > On (07/15/15 01:52), Minchan Kim wrote: > > > > alrighty... again... > > > > > > > > > > > > > > > > /sys/block/zram/compact is a black box. We provide it, we don't > > > > > > thrott

Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-14 Thread Minchan Kim
On Wed, Jul 15, 2015 at 09:21:06AM +0900, Sergey Senozhatsky wrote: > On (07/15/15 01:52), Minchan Kim wrote: > > > alrighty... again... > > > > > > > > > > > > > /sys/block/zram/compact is a black box. We provide it, we don't > > > > > throttle it in the kernel, and user space is absolutely clue

Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-14 Thread Sergey Senozhatsky
On (07/15/15 01:52), Minchan Kim wrote: > > alrighty... again... > > > > > > > > > > /sys/block/zram/compact is a black box. We provide it, we don't > > > > throttle it in the kernel, and user space is absolutely clueless when > > > > it invokes compaction. From some remote (or alternative) point

Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-14 Thread Minchan Kim
Hi Sergey, On Tue, Jul 14, 2015 at 09:29:32PM +0900, Sergey Senozhatsky wrote: > On (07/14/15 09:55), Minchan Kim wrote: > > > It depends on 'big overhead' definition, of course. We don't care > > > that much when compaction is issued by the shrinker, because things > > > are getting bad and we ca

Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-14 Thread Sergey Senozhatsky
On (07/14/15 09:55), Minchan Kim wrote: > > It depends on 'big overhead' definition, of course. We don't care > > that much when compaction is issued by the shrinker, because things > > are getting bad and we can sacrifice performance. But user triggered > > compaction on a I/O pressured device can

Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-13 Thread Minchan Kim
On Tue, Jul 14, 2015 at 09:31:32AM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (07/14/15 08:36), Minchan Kim wrote: > [..] > > > if [ `cat /sys/block/zram/compact` -gt 10 ]; then > > > echo 1 > /sys/block/zram/compact; > > > fi > > > > > > Up until now user spac

Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-13 Thread Sergey Senozhatsky
Hello Minchan, On (07/14/15 08:36), Minchan Kim wrote: [..] > > if [ `cat /sys/block/zram/compact` -gt 10 ]; then > > echo 1 > /sys/block/zram/compact; > > fi > > > > Up until now user space could not tell whether compaction > > will result in any gain. > > First of all, th

Re: [PATCH 0/3] zsmalloc: small compaction improvements

2015-07-13 Thread Minchan Kim
Hello Sergey, On Sat, Jul 11, 2015 at 06:45:29PM +0900, Sergey Senozhatsky wrote: > Hello, > > First two patches introduce new zsmalloc zs_pages_to_compact() > symbol and change zram's `compact' sysfs attribute to be > read-write: > -- write triggers compaction, no changes > -- read returns the n