Re: [PATCH 0/3] x86: structs for cpuid info in x86

2014-09-17 Thread Peter Zijlstra
On Wed, Sep 17, 2014 at 02:37:10PM +0200, Ingo Molnar wrote: > If hpa, tglx or Linus objects I'll yield to that objection > though. > > Opinions, objections? They generally look fine to me. I appreciate the bitfields for readability. I often use the same when having to deal with hardware bitfiel

Re: [PATCH 0/3] x86: structs for cpuid info in x86

2014-09-17 Thread Borislav Petkov
On Wed, Sep 17, 2014 at 02:37:10PM +0200, Ingo Molnar wrote: > Opinions, objections? Can I see those patches please? I can't find them on lkml or on the net - I only see this sub-thread... Thanks. -- Regards/Gruss, Boris. -- -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 0/3] x86: structs for cpuid info in x86

2014-09-17 Thread Ingo Molnar
* Nadav Amit wrote: > > > On 9/16/14 4:22 PM, Ingo Molnar wrote: > > > > * Nadav Amit wrote: > > > >> The code that deals with x86 cpuid fields is hard to follow since it > >> performs > >> many bit operations and does not refer to cpuid field explicitly. To > >> eliminate the need of ope

Re: [PATCH 0/3] x86: structs for cpuid info in x86

2014-09-16 Thread Nadav Amit
On 9/16/14 4:22 PM, Ingo Molnar wrote: > > * Nadav Amit wrote: > >> The code that deals with x86 cpuid fields is hard to follow since it performs >> many bit operations and does not refer to cpuid field explicitly. To >> eliminate the need of openning a spec whenever dealing with cpuid fields

Re: [PATCH 0/3] x86: structs for cpuid info in x86

2014-09-16 Thread Ingo Molnar
* Nadav Amit wrote: > The code that deals with x86 cpuid fields is hard to follow since it performs > many bit operations and does not refer to cpuid field explicitly. To > eliminate the need of openning a spec whenever dealing with cpuid fields, this > patch-set introduces structs that reflect