Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-19 Thread Andi Kleen
On Fri, Sep 18, 2015 at 12:19:19PM -0700, Andrew Morton wrote: > On Wed, 16 Sep 2015 04:55:46 +0200 Andi Kleen wrote: > > > > Under what circumstances will the compiler (or linker?) do this? > > > > Compiler. > > > > > LTO enabled? > > > > Yes it's for LTO. The optimization allows the compil

Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-18 Thread Andrew Morton
On Wed, 16 Sep 2015 04:55:46 +0200 Andi Kleen wrote: > > Under what circumstances will the compiler (or linker?) do this? > > Compiler. > > > LTO enabled? > > Yes it's for LTO. The optimization allows the compiler to drop unused > functions, which is very popular with users (a lot use it to

Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-16 Thread Andrew Morton
On Tue, 15 Sep 2015 17:50:53 -0700 Stephen Boyd wrote: > > > > __iowrite32_copy() is marked __visible. I don't actually know what > > that does and Andi's d47d5c8194579bc changelog (which sucks the big > > one) didn't explain it. Apparently it has something to do with being > > implemented in

Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-15 Thread Andi Kleen
> Under what circumstances will the compiler (or linker?) do this? Compiler. > LTO enabled? Yes it's for LTO. The optimization allows the compiler to drop unused functions, which is very popular with users (a lot use it to get smaller kernel images) -Andi -- a...@linux.intel.com -- Speaking

Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-15 Thread Andrew Morton
On Wed, 16 Sep 2015 04:32:19 +0200 Andi Kleen wrote: > > __iowrite32_copy() is marked __visible. I don't actually know what > > that does and Andi's d47d5c8194579bc changelog (which sucks the big > > one) didn't explain it. Apparently it has something to do with being > > implemented in assembl

Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-15 Thread Andi Kleen
> __iowrite32_copy() is marked __visible. I don't actually know what > that does and Andi's d47d5c8194579bc changelog (which sucks the big > one) didn't explain it. Apparently it has something to do with being > implemented in assembly, but zillions of functions are implemented in > assembly, so

Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-15 Thread Stephen Boyd
On 09/15, Andrew Morton wrote: > On Tue, 15 Sep 2015 12:41:26 -0700 Stephen Boyd wrote: > > > The SMD driver is reading and writing chunks of data to iomem, > > and there's an __iowrite32_copy() function for the writing part, but > > no __ioread32_copy() function for the reading part. This series

Re: [PATCH 0/3] Add __ioread32_copy() and use it

2015-09-15 Thread Andrew Morton
On Tue, 15 Sep 2015 12:41:26 -0700 Stephen Boyd wrote: > The SMD driver is reading and writing chunks of data to iomem, > and there's an __iowrite32_copy() function for the writing part, but > no __ioread32_copy() function for the reading part. This series > adds __ioread32_copy() and uses it in