Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-16 Thread Joe Perches
On Wed, 2016-08-17 at 01:19 +, Bart Van Assche wrote: > On 08/14/16 10:29, Joe Perches wrote: > > On Sun, 2016-08-14 at 17:09 +, Bart Van Assche wrote: > > > My primary concern is how to enable and disable log messages from user > > > space. [] > > I think you are looking for a system wide

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-16 Thread Bart Van Assche
On 08/14/16 10:29, Joe Perches wrote: > On Sun, 2016-08-14 at 17:09 +, Bart Van Assche wrote: >> My primary concern is how to enable and disable log messages from user >> space. Many drivers define their own logging macros and export a bitmask >> that allows to enable and disable logging messag

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Joe Perches
On Sun, 2016-08-14 at 17:09 +, Bart Van Assche wrote: > My primary concern is how to enable and disable log messages from user  > space. Many drivers define their own logging macros and export a bitmask  > that allows to enable and disable logging messages per category. These  > bitmask contro

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Bart Van Assche
On 08/14/16 09:24, Joe Perches wrote: > On Sun, 2016-08-14 at 14:34 +, Bart Van Assche wrote: >> As one can see in be_main.h the "level" argument of macro beiscsi_log() >> is ignored for log levels KERN_EMERG, KERN_ALERT, KERN_CRIT and >> KERN_ERR. So for these log levels beiscsi_log() is a syn

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Joe Perches
On Sun, 2016-08-14 at 14:34 +, Bart Van Assche wrote: > On 08/13/16 13:42, Joe Perches wrote: > > Joe Perches (2): > >   be2iscsi: Coalesce split strings and formats > >   be2iscsi: Use a standard logging style > Hello Joe, Hello Bart. > As one can see in be_main.h the "level" argument of mac

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Bart Van Assche
On 08/13/16 13:42, Joe Perches wrote: > Joe Perches (2): > be2iscsi: Coalesce split strings and formats > be2iscsi: Use a standard logging style Hello Joe, As one can see in be_main.h the "level" argument of macro beiscsi_log() is ignored for log levels KERN_EMERG, KERN_ALERT, KERN_CRIT and