Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-04-01 Thread Neil Armstrong
On 30/03/2019 20:29, Martin Blumenstingl wrote: > Hello Uwe, > > On Mon, Mar 25, 2019 at 9:07 PM Uwe Kleine-König > wrote: > [...] - Does stopping the PWM (i.e. clearing MISC_{A,B}_EN in the MISC_AB register) freeze the output, or is the currently running period completed fi

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-31 Thread Uwe Kleine-König
On Sat, Mar 30, 2019 at 08:29:35PM +0100, Martin Blumenstingl wrote: > Hello Uwe, > > On Mon, Mar 25, 2019 at 9:07 PM Uwe Kleine-König > wrote: > [...] > > > > - Does stopping the PWM (i.e. clearing MISC_{A,B}_EN in the MISC_AB > > > >register) freeze the output, or is the currently running

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-30 Thread Martin Blumenstingl
Hello Uwe, On Mon, Mar 25, 2019 at 9:07 PM Uwe Kleine-König wrote: [...] > > > - Does stopping the PWM (i.e. clearing MISC_{A,B}_EN in the MISC_AB > > >register) freeze the output, or is the currently running period > > >completed first? (The latter is the right behaviour.) > > I don't k

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-26 Thread Martin Blumenstingl
Hi Jerome, On Tue, Mar 26, 2019 at 9:37 AM Jerome Brunet wrote: > > On Mon, 2019-03-25 at 19:04 +0100, Martin Blumenstingl wrote: > > > Thanks for fixing this Martin. > > you're welcome! > > > > > As for the future enhancement, I'd like to know what you have in mind. > > > As I have told you prev

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-26 Thread Martin Blumenstingl
Hello Uwe, On Mon, Mar 25, 2019 at 9:07 PM Uwe Kleine-König wrote: > > Hello Martin, > > On Mon, Mar 25, 2019 at 06:41:57PM +0100, Martin Blumenstingl wrote: > > On Mon, Mar 25, 2019 at 9:41 AM Uwe Kleine-König > > wrote: > > > On Sun, Mar 24, 2019 at 11:02:16PM +0100, Martin Blumenstingl wrote:

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-26 Thread Uwe Kleine-König
Hello, On Tue, Mar 26, 2019 at 10:06:31AM +0100, Neil Armstrong wrote: > On 25/03/2019 18:41, Martin Blumenstingl wrote: > > On Mon, Mar 25, 2019 at 9:41 AM Uwe Kleine-König > > wrote: > >> On Sun, Mar 24, 2019 at 11:02:16PM +0100, Martin Blumenstingl wrote: > >>> Back in January a "BUG: scheduli

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-26 Thread Neil Armstrong
On 25/03/2019 18:41, Martin Blumenstingl wrote: > Hello Uwe, > > On Mon, Mar 25, 2019 at 9:41 AM Uwe Kleine-König > wrote: >> >> Hello Martin, >> >> On Sun, Mar 24, 2019 at 11:02:16PM +0100, Martin Blumenstingl wrote: >>> Back in January a "BUG: scheduling while atomic" error showed up during >>>

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-26 Thread Neil Armstrong
On 26/03/2019 09:37, Jerome Brunet wrote: > On Mon, 2019-03-25 at 19:04 +0100, Martin Blumenstingl wrote: >>> Thanks for fixing this Martin. >> you're welcome! >> >>> As for the future enhancement, I'd like to know what you have in mind. >>> As I have told you previously, I think the clock bindings

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-26 Thread Jerome Brunet
On Mon, 2019-03-25 at 19:04 +0100, Martin Blumenstingl wrote: > > Thanks for fixing this Martin. > you're welcome! > > > As for the future enhancement, I'd like to know what you have in mind. > > As I have told you previously, I think the clock bindings of this driver are > > not great. > > > > T

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Uwe Kleine-König
Hello Martin, On Mon, Mar 25, 2019 at 06:41:57PM +0100, Martin Blumenstingl wrote: > On Mon, Mar 25, 2019 at 9:41 AM Uwe Kleine-König > wrote: > > On Sun, Mar 24, 2019 at 11:02:16PM +0100, Martin Blumenstingl wrote: > > > Analyzing this issue helped me understand the pwm-meson driver better. > >

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Martin Blumenstingl
Hi Jerome, On Mon, Mar 25, 2019 at 10:35 AM Jerome Brunet wrote: > > On Sun, 2019-03-24 at 23:02 +0100, Martin Blumenstingl wrote: > > Back in January a "BUG: scheduling while atomic" error showed up during > > boot on my Meson8b Odroid-C1 (which uses a PWM regulator as CPU supply). > > The call

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Martin Blumenstingl
Hello Uwe, On Mon, Mar 25, 2019 at 9:41 AM Uwe Kleine-König wrote: > > Hello Martin, > > On Sun, Mar 24, 2019 at 11:02:16PM +0100, Martin Blumenstingl wrote: > > Back in January a "BUG: scheduling while atomic" error showed up during > > boot on my Meson8b Odroid-C1 (which uses a PWM regulator as

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Jerome Brunet
On Sun, 2019-03-24 at 23:02 +0100, Martin Blumenstingl wrote: > Back in January a "BUG: scheduling while atomic" error showed up during > boot on my Meson8b Odroid-C1 (which uses a PWM regulator as CPU supply). > The call trace comes down to: > __mutex_lock > clk_prepare_lock > clk_core_get_r

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Uwe Kleine-König
Hello, On Mon, Mar 25, 2019 at 09:41:53AM +0100, Uwe Kleine-König wrote: > If you want to implement further cleanups, my questions and propositions > are: > > - Is there a publicly available manual for this hardware? If yes, you >can add a link to it in the header of the driver. > > - Why

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Uwe Kleine-König
Hello Martin, On Sun, Mar 24, 2019 at 11:02:16PM +0100, Martin Blumenstingl wrote: > Back in January a "BUG: scheduling while atomic" error showed up during > boot on my Meson8b Odroid-C1 (which uses a PWM regulator as CPU supply). > The call trace comes down to: > __mutex_lock > clk_prepare_l