Re: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-29 Thread Vinicius Peixoto
Hi David, On 9/25/24 08:26, David Laight wrote: From: Vinicius Peixoto Sent: 23 September 2024 00:27 Hi all, This patch was developed during a hackathon organized by LKCAMP [1], with the objective of writing KUnit tests, both to introduce people to the kernel development process and to learn

Re: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-29 Thread Vinicius Peixoto
Hi David, On 9/26/24 13:21, David Laight wrote: ... The checksums for the randomly-generated test cases were calculated using a reference implementation [1] and this test compares them against the values yielded by the kernel's implementation. I'd just use a naïve implementation - doesn't rea

RE: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-26 Thread David Laight
... > The checksums for the randomly-generated test cases were calculated > using a reference implementation [1] and this test compares them against > the values yielded by the kernel's implementation. I'd just use a naïve implementation - doesn't really matter if it is a bit slow. Slow is relati

RE: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-25 Thread David Laight
From: Vinicius Peixoto > Sent: 23 September 2024 00:27 > > Hi all, > > This patch was developed during a hackathon organized by LKCAMP [1], > with the objective of writing KUnit tests, both to introduce people to > the kernel development process and to learn about different subsystems > (with the

Re: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-24 Thread Vinicius Peixoto
Hi André, On 9/24/24 6:33 PM, André Almeida wrote: Hey! On 9/23/24 01:26, Vinicius Peixoto wrote: Hi all, This patch was developed during a hackathon organized by LKCAMP [1], with the objective of writing KUnit tests, both to introduce people to the kernel development process and to learn ab

Re: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-24 Thread André Almeida
Hey! On 9/23/24 01:26, Vinicius Peixoto wrote: Hi all, This patch was developed during a hackathon organized by LKCAMP [1], with the objective of writing KUnit tests, both to introduce people to the kernel development process and to learn about different subsystems (with the positive side effec