Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-20 Thread Cyrill Gorcunov
On Mon, Mar 16, 2015 at 03:08:40PM -0700, Kees Cook wrote: > > > >> Ok I think I am finally seeing where you are going. And I like it *a > >> lot* because it allows us to basically replace mmap_sem with rcu > >> (MMF_EXE_FILE_CHANGED being the only user that requires a lock!!), but > >> am afraid i

Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-16 Thread Kees Cook
On Sun, Mar 15, 2015 at 10:05 AM, Cyrill Gorcunov wrote: > On Sun, Mar 15, 2015 at 08:42:05AM -0700, Davidlohr Bueso wrote: >> > > > Yes, this code needs cleanups, I agree. Does this series makes it >> > > > better? >> > > > To me it doesn't, and the diffstat below shows that it blows the code. >

Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-15 Thread Davidlohr Bueso
On Sun, 2015-03-15 at 20:05 +0300, Cyrill Gorcunov wrote: > On Sun, Mar 15, 2015 at 08:42:05AM -0700, Davidlohr Bueso wrote: > > > > > Yes, this code needs cleanups, I agree. Does this series makes it > > > > > better? > > > > > To me it doesn't, and the diffstat below shows that it blows the code

Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-15 Thread Cyrill Gorcunov
On Sun, Mar 15, 2015 at 08:42:05AM -0700, Davidlohr Bueso wrote: > > > > Yes, this code needs cleanups, I agree. Does this series makes it > > > > better? > > > > To me it doesn't, and the diffstat below shows that it blows the code. > > > > > > Looking at some of the caller paths now, I have to d

Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-15 Thread Davidlohr Bueso
On Sun, 2015-03-15 at 16:26 +0100, Oleg Nesterov wrote: > On 03/15, Davidlohr Bueso wrote: > > > > On Sun, 2015-03-15 at 15:21 +0100, Oleg Nesterov wrote: > > > I didn't even read this version, but honestly I don't like it anyway. > > > > > > I leave the review to Cyrill and Konstantin though, If t

Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-15 Thread Oleg Nesterov
On 03/15, Davidlohr Bueso wrote: > > On Sun, 2015-03-15 at 15:21 +0100, Oleg Nesterov wrote: > > I didn't even read this version, but honestly I don't like it anyway. > > > > I leave the review to Cyrill and Konstantin though, If they like these > > changes I won't argue. > > > > But I simply can't

Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-15 Thread Davidlohr Bueso
On Sun, 2015-03-15 at 15:21 +0100, Oleg Nesterov wrote: > I didn't even read this version, but honestly I don't like it anyway. > > I leave the review to Cyrill and Konstantin though, If they like these > changes I won't argue. > > But I simply can't understand why are you doing this. > > > >

Re: [PATCH -next v2 0/4] mm: replace mmap_sem for mm->exe_file serialization

2015-03-15 Thread Oleg Nesterov
I didn't even read this version, but honestly I don't like it anyway. I leave the review to Cyrill and Konstantin though, If they like these changes I won't argue. But I simply can't understand why are you doing this. Yes, this code needs cleanups, I agree. Does this series makes it better? To