Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 12:49:17PM +0100, Borislav Petkov wrote: > On Wed, Mar 27, 2019 at 01:36:28PM +0200, Leon Romanovsky wrote: > > At the end, it is reduced to our usage, we are running QEMU inside > > docker to test kernel changes with limitation on number of CPUs to use. > > The systems are

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Borislav Petkov
On Wed, Mar 27, 2019 at 01:36:28PM +0200, Leon Romanovsky wrote: > At the end, it is reduced to our usage, we are running QEMU inside > docker to test kernel changes with limitation on number of CPUs to use. > The systems are optimized to boot kernel as soon as possible in order > to run tests and

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 12:14:52PM +0100, Borislav Petkov wrote: > On Wed, Mar 27, 2019 at 12:50:24PM +0200, Leon Romanovsky wrote: > > It is how we are internally running verification and development, > > with KERN_DEBUG level, we need it to catch bugs. > > And what is the big deal with seeing tho

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Borislav Petkov
On Wed, Mar 27, 2019 at 12:50:24PM +0200, Leon Romanovsky wrote: > It is how we are internally running verification and development, > with KERN_DEBUG level, we need it to catch bugs. And what is the big deal with seeing those messages? Why are *exactly* those two such a big problem and the gazill

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 11:18:15AM +0100, Borislav Petkov wrote: > On Wed, Mar 27, 2019 at 12:11:33PM +0200, Leon Romanovsky wrote: > > ok, I tested your variant and it still prints a t least on my systems, > > Probably because your loglevel is set to debug. And no, we don't want to > have to enabl

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Borislav Petkov
On Wed, Mar 27, 2019 at 12:11:33PM +0200, Leon Romanovsky wrote: > ok, I tested your variant and it still prints a t least on my systems, Probably because your loglevel is set to debug. And no, we don't want to have to enable some config option in order to see this. Also, the ugly linebreak needs

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Joe Perches
On Wed, 2019-03-27 at 12:11 +0200, Leon Romanovsky wrote: > On Wed, Mar 27, 2019 at 11:53:37AM +0200, Leon Romanovsky wrote: > > On Wed, Mar 27, 2019 at 02:49:02AM -0700, Joe Perches wrote: > > > On Wed, 2019-03-27 at 11:38 +0200, Leon Romanovsky wrote: > > > > On Wed, Mar 27, 2019 at 02:17:40AM -0

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 11:53:37AM +0200, Leon Romanovsky wrote: > On Wed, Mar 27, 2019 at 02:49:02AM -0700, Joe Perches wrote: > > On Wed, 2019-03-27 at 11:38 +0200, Leon Romanovsky wrote: > > > On Wed, Mar 27, 2019 at 02:17:40AM -0700, Joe Perches wrote: > > > > On Wed, 2019-03-27 at 11:09 +0200,

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 02:49:02AM -0700, Joe Perches wrote: > On Wed, 2019-03-27 at 11:38 +0200, Leon Romanovsky wrote: > > On Wed, Mar 27, 2019 at 02:17:40AM -0700, Joe Perches wrote: > > > On Wed, 2019-03-27 at 11:09 +0200, Leon Romanovsky wrote: > > > > Kernel is booted with less possible CPUs

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Joe Perches
On Wed, 2019-03-27 at 11:38 +0200, Leon Romanovsky wrote: > On Wed, Mar 27, 2019 at 02:17:40AM -0700, Joe Perches wrote: > > On Wed, 2019-03-27 at 11:09 +0200, Leon Romanovsky wrote: > > > Kernel is booted with less possible CPUs (possible_cpus kernel boot > > > option) than available CPUs will hav

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Leon Romanovsky
On Wed, Mar 27, 2019 at 02:17:40AM -0700, Joe Perches wrote: > On Wed, 2019-03-27 at 11:09 +0200, Leon Romanovsky wrote: > > Kernel is booted with less possible CPUs (possible_cpus kernel boot > > option) than available CPUs will have prints like this: > [] > > diff --git a/arch/x86/kernel/apic/api

Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

2019-03-27 Thread Joe Perches
On Wed, 2019-03-27 at 11:09 +0200, Leon Romanovsky wrote: > Kernel is booted with less possible CPUs (possible_cpus kernel boot > option) than available CPUs will have prints like this: [] > diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c [] > @@ -2305,9 +2305,9 @@ int generi