Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-14 Thread Yisheng Xie
On 2017/8/14 17:34, Minchan Kim wrote: > On Mon, Aug 14, 2017 at 05:24:16PM +0800, Yisheng Xie wrote: >> Hi, Minchan >> >> Thanks for your comment! >> On 2017/8/14 16:08, Minchan Kim wrote: >>> Hi Yisheng, >>> >>> Thanks for the all fixup! >>> A minor nitpick below: >>> >>> On Fri, Aug 11, 2017 a

Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-14 Thread Minchan Kim
On Mon, Aug 14, 2017 at 05:24:16PM +0800, Yisheng Xie wrote: > Hi, Minchan > > Thanks for your comment! > On 2017/8/14 16:08, Minchan Kim wrote: > > Hi Yisheng, > > > > Thanks for the all fixup! > > A minor nitpick below: > > > > On Fri, Aug 11, 2017 at 09:10:32AM +0800, Yisheng Xie wrote: > >>

Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-14 Thread Yisheng Xie
Hi, Minchan Thanks for your comment! On 2017/8/14 16:08, Minchan Kim wrote: > Hi Yisheng, > > Thanks for the all fixup! > A minor nitpick below: > > On Fri, Aug 11, 2017 at 09:10:32AM +0800, Yisheng Xie wrote: >> The compr_data_size is a stat for compressed size of pages stored, which >> should

Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-14 Thread Minchan Kim
Hi Yisheng, Thanks for the all fixup! A minor nitpick below: On Fri, Aug 11, 2017 at 09:10:32AM +0800, Yisheng Xie wrote: > The compr_data_size is a stat for compressed size of pages stored, which > should add comp_len when we compresse a page. > > Meanwhile fix typos in comment: > * ZRAM_SAME m

Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-10 Thread Yisheng Xie
On 2017/8/11 10:07, Yisheng Xie wrote: > > > On 2017/8/11 9:38, Sergey Senozhatsky wrote: >> On (08/11/17 10:35), Sergey Senozhatsky wrote: >>> On (08/11/17 09:10), Yisheng Xie wrote: The compr_data_size is a stat for compressed size of pages stored, which should add comp_len when we

Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-10 Thread Yisheng Xie
On 2017/8/11 9:38, Sergey Senozhatsky wrote: > On (08/11/17 10:35), Sergey Senozhatsky wrote: >> On (08/11/17 09:10), Yisheng Xie wrote: >>> The compr_data_size is a stat for compressed size of pages stored, which >>> should add comp_len when we compresse a page. >>> >>> Meanwhile fix typos in co

Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-10 Thread Sergey Senozhatsky
On (08/11/17 10:35), Sergey Senozhatsky wrote: > On (08/11/17 09:10), Yisheng Xie wrote: > > The compr_data_size is a stat for compressed size of pages stored, which > > should add comp_len when we compresse a page. > > > > Meanwhile fix typos in comment: > > * ZRAM_SAME means page consists the sa

Re: [PATCH -next] zram: fix compr_data_size stat

2017-08-10 Thread Sergey Senozhatsky
On (08/11/17 09:10), Yisheng Xie wrote: > The compr_data_size is a stat for compressed size of pages stored, which > should add comp_len when we compresse a page. > > Meanwhile fix typos in comment: > * ZRAM_SAME means page consists the same element not the entirely zero page > * read_from_bdev_as