Re: [PATCH -mm 2/2] Introduce freezer flags (rev. 2)

2007-04-28 Thread Pavel Machek
On Sat 2007-04-28 11:40:21, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Move all of the freezer-related flags to a separate field in task_struct and > introduce functions to operate them using set_bit() etc. > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]> A

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-28 Thread Pavel Machek
Hi! > > > > > > +#ifdef CONFIG_FREEZER > > > > > > + /* Used by the process freezer, defined in freezer.h */ > > > > > > + unsigned int freezer_flags; > > > > > > > > > > unsigned long freezer_flags; ?? > > > > > > > > I guess so. > > > > > > Still, on x86_64, for example, we'll waste 4 byt

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Rafael J. Wysocki
On Saturday, 28 April 2007 00:07, Pavel Machek wrote: > Hi! > > > > > > +#ifdef CONFIG_FREEZER > > > > > + /* Used by the process freezer, defined in freezer.h */ > > > > > + unsigned int freezer_flags; > > > > > > > > unsigned long freezer_flags; ?? > > > > > > I guess so. > > > > Stil

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Pavel Machek
Hi! > > > > +#ifdef CONFIG_FREEZER > > > > + /* Used by the process freezer, defined in freezer.h */ > > > > + unsigned int freezer_flags; > > > > > > unsigned long freezer_flags; ?? > > > > I guess so. > > Still, on x86_64, for example, we'll waste 4 bytes by using 'unsigned long'

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Rafael J. Wysocki
On Friday, 27 April 2007 23:49, Rafael J. Wysocki wrote: > On Friday, 27 April 2007 23:40, Gautham R Shenoy wrote: > > On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > > > Move all of the freezer-related flags to a separat

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Gautham R Shenoy
On Fri, Apr 27, 2007 at 11:49:35PM +0200, Rafael J. Wysocki wrote: > > > - > > > +#ifdef CONFIG_FREEZER > > > + /* Used by the process freezer, defined in freezer.h */ > > > + unsigned int freezer_flags; > > > > unsigned long freezer_flags; ?? > > I guess so. > > > Else it throws the following w

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Rafael J. Wysocki
On Friday, 27 April 2007 23:40, Gautham R Shenoy wrote: > On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Move all of the freezer-related flags to a separate field in task_struct and > > introduce functions to operate them

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Gautham R Shenoy
On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Move all of the freezer-related flags to a separate field in task_struct and > introduce functions to operate them using set_bit() etc. > > > Index: linux-2.6.21-rc7-mm2/include/l

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Gautham R Shenoy
On Fri, Apr 27, 2007 at 06:19:40PM +0200, Sam Ravnborg wrote: > On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote: > > > --- linux-2.6.21-rc7-mm2.orig/kernel/fork.c > > +++ linux-2.6.21-rc7-mm2/kernel/fork.c > > @@ -921,11 +921,14 @@ static inline void copy_flags(unsigned l > > {

Re: [PATCH -mm 2/2] Introduce freezer flags

2007-04-27 Thread Sam Ravnborg
On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote: > --- linux-2.6.21-rc7-mm2.orig/kernel/fork.c > +++ linux-2.6.21-rc7-mm2/kernel/fork.c > @@ -921,11 +921,14 @@ static inline void copy_flags(unsigned l > { > unsigned long new_flags = p->flags; > > - new_flags &= ~(PF_