Re: [PATCH -mm] splice: Disable vmsplice on nommu.

2007-09-11 Thread David Howells
Jens Axboe <[EMAIL PROTECTED]> wrote: > > > It's a bit of a sledge hammer... Since get_user_pages() appears to work > > > on nummu, we can just disable the vmsplice-to-userspace bits and leave > > > the (working) vmsplice-from-userspace in place. > > > > That sounds about right. I don't think yo

Re: [PATCH -mm] splice: Disable vmsplice on nommu.

2007-09-11 Thread Jens Axboe
On Tue, Sep 11 2007, David Howells wrote: > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > It's a bit of a sledge hammer... Since get_user_pages() appears to work > > on nummu, we can just disable the vmsplice-to-userspace bits and leave > > the (working) vmsplice-from-userspace in place. > > That s

Re: [PATCH -mm] splice: Disable vmsplice on nommu.

2007-09-11 Thread David Howells
Jens Axboe <[EMAIL PROTECTED]> wrote: > It's a bit of a sledge hammer... Since get_user_pages() appears to work > on nummu, we can just disable the vmsplice-to-userspace bits and leave > the (working) vmsplice-from-userspace in place. That sounds about right. I don't think you can do the latter

Re: [PATCH -mm] splice: Disable vmsplice on nommu.

2007-09-11 Thread Jens Axboe
On Tue, Sep 11 2007, Paul Mundt wrote: > The vmsplice rework in -mm breaks nommu: > > fs/built-in.o: In function `splice_setup_vma': > fs/splice.c:1272: undefined reference to `may_expand_vm' > fs/splice.c:1272: undefined reference to `protection_map' > fs/splice.c:1272: undefined reference to `in