RE: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-18 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method > > On 02/16/2013 12:28 AM, Ric Mason wrote: > > On 02/04/2013 08:23 AM, Minchan Kim wrote: > >> + for object mapping. You ca

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-18 Thread Seth Jennings
On 02/16/2013 12:28 AM, Ric Mason wrote: > On 02/04/2013 08:23 AM, Minchan Kim wrote: >> Zsmalloc has two methods 1) copy-based and 2) pte based to access >> allocations that span two pages. >> You can see history why we supported two approach from [1]. >> >> But it was bad choice that adding hard

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-15 Thread Ric Mason
On 02/04/2013 08:23 AM, Minchan Kim wrote: Zsmalloc has two methods 1) copy-based and 2) pte based to access allocations that span two pages. You can see history why we supported two approach from [1]. But it was bad choice that adding hard coding to select architecture which want to use pte bas

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-05 Thread Minchan Kim
Hi Greg, On Tue, Feb 05, 2013 at 05:42:59PM -0800, Greg Kroah-Hartman wrote: > On Wed, Feb 06, 2013 at 10:17:21AM +0900, Minchan Kim wrote: > > > > > Did you test this? I don't see the new config value you added > > > > > actually > > > > > do anything in this code. Also, if I select it incorre

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-05 Thread Greg Kroah-Hartman
On Wed, Feb 06, 2013 at 10:17:21AM +0900, Minchan Kim wrote: > > > > Did you test this? I don't see the new config value you added actually > > > > do anything in this code. Also, if I select it incorrectly on ARM, or > > > > > > *slaps self* > > > > Ok, so I'll drop this patch now. As for wha

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-05 Thread Minchan Kim
On Tue, Feb 05, 2013 at 11:25:20AM -0800, Greg Kroah-Hartman wrote: > On Tue, Feb 05, 2013 at 09:08:54AM +0900, Minchan Kim wrote: > > Hi Greg, > > > > On Mon, Feb 04, 2013 at 10:51:46AM -0800, Greg Kroah-Hartman wrote: > > > On Mon, Feb 04, 2013 at 09:23:41AM +0900, Minchan Kim wrote: > > > > Zsm

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-05 Thread Greg Kroah-Hartman
On Tue, Feb 05, 2013 at 09:08:54AM +0900, Minchan Kim wrote: > Hi Greg, > > On Mon, Feb 04, 2013 at 10:51:46AM -0800, Greg Kroah-Hartman wrote: > > On Mon, Feb 04, 2013 at 09:23:41AM +0900, Minchan Kim wrote: > > > Zsmalloc has two methods 1) copy-based and 2) pte based to access > > > allocations

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-04 Thread Minchan Kim
Hi Greg, On Mon, Feb 04, 2013 at 10:51:46AM -0800, Greg Kroah-Hartman wrote: > On Mon, Feb 04, 2013 at 09:23:41AM +0900, Minchan Kim wrote: > > Zsmalloc has two methods 1) copy-based and 2) pte based to access > > allocations that span two pages. > > You can see history why we supported two approa

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-04 Thread Greg Kroah-Hartman
On Mon, Feb 04, 2013 at 09:23:41AM +0900, Minchan Kim wrote: > Zsmalloc has two methods 1) copy-based and 2) pte based to access > allocations that span two pages. > You can see history why we supported two approach from [1]. > > But it was bad choice that adding hard coding to select architecture

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-03 Thread Minchan Kim
On Sun, Feb 03, 2013 at 08:02:09PM -0600, Simon Jeons wrote: > On Mon, 2013-02-04 at 09:23 +0900, Minchan Kim wrote: > > Zsmalloc has two methods 1) copy-based and 2) pte based to access > > allocations that span two pages. > > You can see history why we supported two approach from [1]. > > > > Bu

Re: [PATCH] zsmalloc: Add Kconfig for enabling PTE method

2013-02-03 Thread Simon Jeons
On Mon, 2013-02-04 at 09:23 +0900, Minchan Kim wrote: > Zsmalloc has two methods 1) copy-based and 2) pte based to access > allocations that span two pages. > You can see history why we supported two approach from [1]. > > But it was bad choice that adding hard coding to select architecture > whic