Re: [PATCH] zram: make rw_page opeartion return 0

2014-11-07 Thread Sergey Senozhatsky
Hello Minchan, On (11/07/14 13:55), Minchan Kim wrote: > On Thu, Nov 06, 2014 at 10:43:42PM +0900, Sergey Senozhatsky wrote: > > Hello, > > > > On (11/05/14 09:10), Minchan Kim wrote: > > > zram_rw_page returns error code to upper layer with PG_error flag > > > of the page but it should be wrong

Re: [PATCH] zram: make rw_page opeartion return 0

2014-11-06 Thread Minchan Kim
Hello Sergey, On Thu, Nov 06, 2014 at 10:43:42PM +0900, Sergey Senozhatsky wrote: > Hello, > > On (11/05/14 09:10), Minchan Kim wrote: > > zram_rw_page returns error code to upper layer with PG_error flag > > of the page but it should be wrong usage. If submitted IO is > > hard fail(ie, I/O again

Re: [PATCH] zram: make rw_page opeartion return 0

2014-11-06 Thread Sergey Senozhatsky
On (11/06/14 22:43), Sergey Senozhatsky wrote: > Hello, > On (11/05/14 09:10), Minchan Kim wrote: > > zram_rw_page returns error code to upper layer with PG_error flag > > of the page but it should be wrong usage. If submitted IO is > > hard fail(ie, I/O again will not succeed), we should return 0,

Re: [PATCH] zram: make rw_page opeartion return 0

2014-11-06 Thread Sergey Senozhatsky
Hello, On (11/05/14 09:10), Minchan Kim wrote: > zram_rw_page returns error code to upper layer with PG_error flag > of the page but it should be wrong usage. If submitted IO is > hard fail(ie, I/O again will not succeed), we should return 0, > indicating that the submission was successful but the