Re: [PATCH] xfs: allow disabling xfs tracepoints via Kconfig

2019-02-05 Thread Rasmus Villemoes
On 05/02/2019 00.13, Dave Chinner wrote: > On Mon, Feb 04, 2019 at 11:12:57PM +0100, Rasmus Villemoes wrote: >> On 04/02/2019 22.53, Dave Chinner wrote: >>> On Mon, Feb 04, 2019 at 10:20:35PM +0100, Rasmus Villemoes wrote: linux/tracepoints.h allows individual subsystems to disable their

Re: [PATCH] xfs: allow disabling xfs tracepoints via Kconfig

2019-02-04 Thread Dave Chinner
On Mon, Feb 04, 2019 at 11:12:57PM +0100, Rasmus Villemoes wrote: > On 04/02/2019 22.53, Dave Chinner wrote: > > On Mon, Feb 04, 2019 at 10:20:35PM +0100, Rasmus Villemoes wrote: > >> linux/tracepoints.h allows individual subsystems to disable their > >> tracepoints. Add such a knob for xfs. Disabl

Re: [PATCH] xfs: allow disabling xfs tracepoints via Kconfig

2019-02-04 Thread Rasmus Villemoes
On 04/02/2019 22.53, Dave Chinner wrote: > On Mon, Feb 04, 2019 at 10:20:35PM +0100, Rasmus Villemoes wrote: >> linux/tracepoints.h allows individual subsystems to disable their >> tracepoints. Add such a knob for xfs. Disabling XFS_TRACEPOINTS >> reduces the resident size of xfs.ko by about a thir

Re: [PATCH] xfs: allow disabling xfs tracepoints via Kconfig

2019-02-04 Thread Dave Chinner
On Mon, Feb 04, 2019 at 10:20:35PM +0100, Rasmus Villemoes wrote: > linux/tracepoints.h allows individual subsystems to disable their > tracepoints. Add such a knob for xfs. Disabling XFS_TRACEPOINTS > reduces the resident size of xfs.ko by about a third, or ~350 KiB. Ok, now we can't debug typica

Re: [PATCH] xfs: allow disabling xfs tracepoints via Kconfig

2019-02-04 Thread Darrick J. Wong
On Mon, Feb 04, 2019 at 10:20:35PM +0100, Rasmus Villemoes wrote: > linux/tracepoints.h allows individual subsystems to disable their > tracepoints. Add such a knob for xfs. Disabling XFS_TRACEPOINTS > reduces the resident size of xfs.ko by about a third, or ~350 KiB. LOL. :) > $ size /tmp/xfs/{a