Re: [PATCH] x86 efi: bugfix interrupt disabling sequence

2013-09-25 Thread Matt Fleming
On Mon, 23 Sep, at 11:45:28AM, Bart Kuivenhoven wrote: > The problem in efi_main was that the idt was cleared before the > interrupts were disabled. > > The UEFI spec states that interrupts aren't used so this shouldn't be > too much of a problem. Peripherals however don't necessarily know about >

Re: [PATCH] x86 efi: bugfix interrupt disabling sequence

2013-09-23 Thread Bart Kuivenhoven
On Sat, 2013-09-21 at 16:41 +0100, Matt Fleming wrote: > On Fri, 20 Sep, at 10:21:26PM, Bart Kuivenhoven wrote: > > Well, isn't it so, that the kernel expects a setup in which interrupts > > are disabled before the decompressed image is loaded? > > Yes, but I wasn't advocating leaving interrupts

Re: [PATCH] x86 efi: bugfix interrupt disabling sequence

2013-09-21 Thread Matt Fleming
On Fri, 20 Sep, at 10:21:26PM, Bart Kuivenhoven wrote: > Well, isn't it so, that the kernel expects a setup in which interrupts > are disabled before the decompressed image is loaded? Yes, but I wasn't advocating leaving interrupts enabled, rather, because interrupts are disabled we don't need to

Re: [PATCH] x86 efi: bugfix interrupt disabling sequence

2013-09-21 Thread Ingo Molnar
* Bart Kuivenhoven wrote: > On Fri, 2013-09-20 at 16:28 +0100, Matt Fleming wrote: > > On Wed, 18 Sep, at 07:28:53PM, Bart Kuivenhoven wrote: > > > The problem in efi_main was that the idt was cleared before the > > > interrupts were disabled. > > > > > > The UEFI spec states that interrupts ar

Re: [PATCH] x86 efi: bugfix interrupt disabling sequence

2013-09-20 Thread Bart Kuivenhoven
On Fri, 2013-09-20 at 16:28 +0100, Matt Fleming wrote: > On Wed, 18 Sep, at 07:28:53PM, Bart Kuivenhoven wrote: > > The problem in efi_main was that the idt was cleared before the > > interrupts were disabled. > > > > The UEFI spec states that interrupts aren't used so this shouldn't be > > too mu

Re: [PATCH] x86 efi: bugfix interrupt disabling sequence

2013-09-20 Thread Matt Fleming
On Wed, 18 Sep, at 07:28:53PM, Bart Kuivenhoven wrote: > The problem in efi_main was that the idt was cleared before the > interrupts were disabled. > > The UEFI spec states that interrupts aren't used so this shouldn't be > too much of a problem. Peripherals however don't necessarily know about >